Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Travis tests seem to pass but they aren't #135

Open
mkozjak opened this issue Jun 6, 2019 · 1 comment
Open

Travis tests seem to pass but they aren't #135

mkozjak opened this issue Jun 6, 2019 · 1 comment

Comments

@mkozjak
Copy link
Owner

mkozjak commented Jun 6, 2019

https://travis-ci.org/mkozjak/node-telnet-client/jobs/542229955
@mkozjak mkozjak mentioned this issue Jun 6, 2019
Merged
@palavrov
Copy link
Contributor

As told in #134 promise based API warns for unhandled promises - this is implementation problem because all API functions return a promise so these promises must be correctly handled in tests, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@palavrov @mkozjak