Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrustedDevice fails because of JSONField #70

Open
pmosse opened this issue Oct 31, 2022 · 13 comments
Open

TrustedDevice fails because of JSONField #70

pmosse opened this issue Oct 31, 2022 · 13 comments

Comments

@pmosse
Copy link

pmosse commented Oct 31, 2022

Captura de pantalla 2022-10-31 a las 19 59 07

Hello!

I am using jsonfield 3.1.0, Django 3.2.6 and Python 3.8. When trying to add a TrustedDevice (following the example code, already integrated into my application, I am getting this error.

@mkalioby
Copy link
Owner

mkalioby commented Nov 1, 2022

Sorry, to hear that, I acknowledge the issue and will solve as soon as possible

@mkalioby
Copy link
Owner

mkalioby commented Nov 2, 2022

Hello, I fixed the issue and I did some refurbishing for trusted device page like adding QR for link
You can find the fix in version 2.7.0rc1.
Please validate it and let me know so it gets released.

@pmosse
Copy link
Author

pmosse commented Nov 2, 2022

Thank you for the fast reply! Now when I try to add a TrustedDevice it says I can't add more devices and I should delete the previous one (but I don't actually have any). When I refresh the page, I see it created 2 Trusted Devices for me...

A separated question: does this support Face ID in iOS?

Thank you!

@mkalioby
Copy link
Owner

mkalioby commented Nov 2, 2022

Thank you for the fast reply! Now when I try to add a TrustedDevice it says I can't add more devices and I should delete the previous one (but I don't actually have any). When I refresh the page, I see it created 2 Trusted Devices for me...

These are the failed registrations so you can delete them and try again.

A separated question: does this support Face ID in iOS?

Not trusted device, but FIDO2 which is supported by the library does and it even supports pasakeys

Thank you!

@pmosse
Copy link
Author

pmosse commented Nov 2, 2022

Great! But the failed registrations are created despite I get a message saying that I can't add more devices...
So it goes like this: I don't have any devices registered, when I try to register one it says I can't register more... and it creates these failed devices...

@mkalioby
Copy link
Owner

mkalioby commented Nov 2, 2022

Did you add any other 2FA method before trusted device?

@pmosse
Copy link
Author

pmosse commented Nov 3, 2022

Yes, just one FIDO2

@mkalioby
Copy link
Owner

mkalioby commented Nov 3, 2022

Did you login with fido2 before registering trusted device enrollment?

@pmosse
Copy link
Author

pmosse commented Nov 3, 2022

Yes, I did. I mean once I activate 2FA for a user (in this case, FIDO2), I will always login with it, right? I am doing the tests with a single user which has FIDO2 activated. But if your question is if I used it immediately before, I didn't. I just opened the browser in my mobile and it remembered me.

@mkalioby
Copy link
Owner

mkalioby commented Nov 4, 2022

So is it working?

@pmosse
Copy link
Author

pmosse commented Nov 4, 2022

No no, same situation as I explained before. Adding a trusted device fails but at the same time it creates 2 invalid records. If you send me a Telegram user or email I can share a video

@mkalioby
Copy link
Owner

mkalioby commented Nov 4, 2022

Please make sure of the following before adding a trusted device

  • you have another 2FA registered
  • login with that factor and then try to register a trusted device

Github allows videos in comments now, btw.

@pmosse
Copy link
Author

pmosse commented Nov 4, 2022

I followed those steps but I get the exact same result, unfortunately. About the video, I prefer not to share it publicly as it has company info. If you want to check it you can write me here https://privnote.com/S27n7jpS#CJXqXiFIP, otherwise we can continue here :)

mkalioby added a commit that referenced this issue Dec 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants