Fix linking with an upcoming version of Rtools on Windows where netcdf needs curl. #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #141 +/- ##
=======================================
Coverage 80.99% 80.99%
=======================================
Files 13 13
Lines 5973 5973
=======================================
Hits 4838 4838
Misses 1135 1135 ☔ View full report in Codecov by Sentry. |
|
Thanks for this patch @kalibera . I will send an update to CRAN in the next few weeks. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the package to build with an upcoming version of Rtools on Windows. Netcdf now needs also libcurl, but the configure file doesn't assume that, so the patch resorts to pkg-config. Tested also with Rtools43 and Rtools42.