Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accept custom data.frame in write_refs #23

Open
LukasWallrich opened this issue Sep 26, 2022 · 1 comment
Open

Accept custom data.frame in write_refs #23

LukasWallrich opened this issue Sep 26, 2022 · 1 comment

Comments

@LukasWallrich
Copy link

It would be great to accept a custom data.frame for write_refs ... or otherwise allow the user to change the tag naming.

It looks like the custom dataframe was supposed to be implemented (see below) - happy to submit a PR if you would like to allow this to be passed on to write_ris?

synthesisr/R/write_refs.R

Lines 146 to 149 in c406bc9

}else if(inherits(tag_naming, "data.frame")){
if(any(!(c("code", "field") %in% colnames(tag_naming)))){
stop("if a data.frame is supplied to replace_tags, it must contain columns 'code' & 'field'.")
}

@LukasWallrich
Copy link
Author

I have now implemented this for use in CiteSource - happy to submit this function as a PR. Pls just let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant