Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

read_refs() introducing 'and' in author lists between first and last names #17

Open
nealhaddaway opened this issue Mar 11, 2022 · 6 comments · May be fixed by #19
Open

read_refs() introducing 'and' in author lists between first and last names #17

nealhaddaway opened this issue Mar 11, 2022 · 6 comments · May be fixed by #19
Assignees
@mjwestgate
Labels
bug Something isn't working

Comments

@nealhaddaway
Copy link
Collaborator

read_refs() is introducing unwarranted 'and' between first and last names of authors.
@nealhaddaway nealhaddaway changed the title read_refs() introducing 'rand' in author lists between first and last names read_refs() introducing 'and' in author lists between first and last names Mar 11, 2022
@chriscpritchard
Copy link

I'm looking into this, but I can't seem to replicate the issue. Would you be able to upload an RIS file where this occurs?

@nealhaddaway
Copy link
Collaborator Author

I've emailed you a file - don't think I can publish it here..

@chriscpritchard
Copy link

Yup got it, I'll look into it over the next few days

@chriscpritchard chriscpritchard linked a pull request Mar 16, 2022 that will close this issue
Open
@chriscpritchard
Copy link

Added a PR for this, looks like it was a case of not anticipating authors formatted in this way @nealhaddaway

@nealhaddaway
Copy link
Collaborator Author

nealhaddaway commented Mar 16, 2022 via email

@nealhaddaway nealhaddaway added the bug Something isn't working label Apr 10, 2022
@nealhaddaway
Copy link
Collaborator Author

@mjwestgate - ready for a PR now that fixes this :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mjwestgate mjwestgate

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add regex to clean_authors to deal with semicolons chriscpritchard/synthesisr
3 participants
@chriscpritchard @mjwestgate @nealhaddaway