-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
read_refs()
doesn't load all RIS files properly
#15
Comments
Hi Gjalt-Jorn - sorry for the delay on getting to this - I think it's fixed now. Basically those files were getting incorrectly parsed using
There are still some weird things in there (e.g. "chemicals" is probably wrong), but the basic information looks correct. Let me know if there is anything else you need me to check. |
Well, for our sysrev at least this is perfect! Awesome, thank you so much! One that still acts oddly is the Embase/OVID one (in our repo it's at https://gitlab.com/extending-the-earcheck/living-review/-/blob/master/queries/literature_search_02/Embase_Ovid_N953.ris (check https://gitlab.com/extending-the-earcheck/living-review/-/raw/master/queries/literature_search_02/Embase_Ovid_N953.ris for the raw version), but I think that's because it probably violates the RIS standard, no? It includes lines that show query information in between the records. I'll 'manually' (i.e. with script :-)) strip that for now. However, if this is how Ovid exports Embase results by default (might also have been a setting applied by my collaborator who exported the hits), maybe good to check for that? I'll send the link to the code once I pushed it :-) For now, thank you very much! I'll leave this open for a little bit to maybe elaborate if something else turns up. For now, however, again, thank you very much!!! 🙏 |
Awesome! Fixed that last error, and it all seems to work perfectly now! I added some preprocessing, where all lines outside of records are removed from the RIS files.* This code is here (especially these lines), but these are the most important lines:
So basically, get all lines matching the TY tag and the ER tag, then all the lines in between each pair, then index the string to remove all other lines. That solves that Embase/Ovid problem, and should be safe to run in any case (which this code does, without apprently problems). Would you like me to adapt this, integrate it in
|
Hi Gjalt-Jorn, I just had a look at this - the files have moved a bit which might mean I've got something wrong - but using the GitHub version of Am I missing something? I'm happy to look at this again if that would help! Martin |
For a systematic review (duh 😬) we're loading RIS files exported from:
These work fine for the first few, but the fields aren't imported properly from Cinahl and Embase. I can't figure out why - the Cinahl file, for example, seems pretty straightforward RIS (https://gitlab.com/extending-the-earcheck/living-review/-/blob/master/queries/literature_search_02/CINAHL_Ebsco_N236.ris), e.g.:
But if I then run:
It shows:
So it doesn't recorgnize the
T1
field as title - but it does drop it from the data frame for some reason. I hope to figure out how the import functions were designed exactly so I can debug this myself (and submit a pull request), but I'm not sure I'll manage, and and also posting this here in case others run into similar problems.The text was updated successfully, but these errors were encountered: