Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devise a process for syncing the Integration module's version number with Workbench #31

Open
mjordan opened this issue Aug 28, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@mjordan
Copy link
Owner

mjordan commented Aug 28, 2023

We need a process for synchronizing the version number of the Integration module with Workbench. Workbench's check_integration_module_version() function compares the version of the target Drupal's Integration module (which it fetches via the "IslandoraWorkbenchIntegrationVersionController" REST endpoint) so that Workbench can use new functionality enabled by updates to the target Integration module.

Currently the version number hard coded in Workbench is 1.0. Our problem is that if we change the minor version number of the Integration module (i.e., from 1.0.x to 1.1.x) without updating Workbench, Workbench will cease to work since its check for the current version of the Integration module will fail.

I suggest that we introduce a Workbench configuration setting with a default value of 1.0 (for now) so that users can set it higher if they need to, e.g. to use new features that depend on a later version of the module. We can update this default in Workbench but if users don't want to update Workbench, they can at least adjust the minimum Integration module version back to 1.0 in their configs if they need to.

@mjordan mjordan added the bug Something isn't working label Aug 28, 2023
@mjordan mjordan self-assigned this Aug 28, 2023
mjordan added a commit that referenced this issue Aug 28, 2023
@mjordan mjordan changed the title Revert version number from 1.1.0 to 1.0.0 until we have a process for syncing Workbnech Devise a process for syncing the Integration module's version number with Workbench Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant