Skip to content

Commit

Permalink
Remove auxiliary functions from hysen class (#780)
Browse files Browse the repository at this point in the history
  • Loading branch information
felipediel authored Apr 9, 2024
1 parent d7ed985 commit 06c91ae
Showing 1 changed file with 5 additions and 11 deletions.
16 changes: 5 additions & 11 deletions broadlink/climate.py
Original file line number Diff line number Diff line change
Expand Up @@ -43,28 +43,22 @@ def send_request(self, request: t.Sequence[int]) -> bytes:

return payload[0x02:p_len]

def _room_or_ext_temp_logic(self, payload, base_index):
def _decode_temp(self, payload, base_index):
base_temp = payload[base_index] / 2.0
add_offset = (payload[4] >> 3) & 1 # should offset be added?
offset_raw_value = (payload[17] >> 4) & 3 # offset value
offset = (offset_raw_value + 1) / 10 if add_offset else 0.0
return base_temp + offset

def _room_temp_logic(self, payload):
return self._room_or_ext_temp_logic(payload, 5)

def _ext_temp_logic(self, payload):
return self._room_or_ext_temp_logic(payload, 18)

def get_temp(self) -> float:
"""Return the room temperature in degrees celsius."""
payload = self.send_request([0x01, 0x03, 0x00, 0x00, 0x00, 0x08])
return self._room_temp_logic(payload)
return self._decode_temp(payload, 5)

def get_external_temp(self) -> float:
"""Return the external temperature in degrees celsius."""
payload = self.send_request([0x01, 0x03, 0x00, 0x00, 0x00, 0x08])
return self._ext_temp_logic(payload)
return self._decode_temp(payload, 18)

def get_full_status(self) -> dict:
"""Return the state of the device.
Expand All @@ -78,7 +72,7 @@ def get_full_status(self) -> dict:
data["active"] = (payload[4] >> 4) & 1
data["temp_manual"] = (payload[4] >> 6) & 1
data["heating_cooling"] = (payload[4] >> 7) & 1
data["room_temp"] = self._room_temp_logic(payload)
data["room_temp"] = self._decode_temp(payload, 5)
data["thermostat_temp"] = payload[6] / 2.0
data["auto_mode"] = payload[7] & 0xF
data["loop_mode"] = payload[7] >> 4
Expand All @@ -93,7 +87,7 @@ def get_full_status(self) -> dict:
data["fre"] = payload[15]
data["poweron"] = payload[16]
data["unknown"] = payload[17]
data["external_temp"] = self._ext_temp_logic(payload)
data["external_temp"] = self._decode_temp(payload, 18)
data["hour"] = payload[19]
data["min"] = payload[20]
data["sec"] = payload[21]
Expand Down

0 comments on commit 06c91ae

Please sign in to comment.