Update supported Elixir, OTP and Ecto versions #37
+265
−89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
kianmeng
reviewed
Sep 22, 2024
| include: | ||
| - elixir-version: 1.12.x | ||
| - elixir-version: 1.17.x |
There was a problem hiding this comment.
We should also include OTP 26 and 27 as well?
There was a problem hiding this comment.
Yep absolutely, I just wanted to make all OTP 25 builds go green and then check for 26 and 27 after 🙂
There was a problem hiding this comment.
@kianmeng I added a few!
- elixir-version: 1.17.x
otp-version: 27.x
- elixir-version: 1.17.x
otp-version: 26.x
- elixir-version: 1.16.x
otp-version: 26.x
- elixir-version: 1.15.x
otp-version: 26.x🙌
remi
force-pushed
the
feature/bump-ee-in-ci-remi
branch
from
ca209e0
to
b8101ed
Compare
simonprev
approved these changes
Sep 23, 2024
|
🥳 🥳 🥳 🥳 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📖 Description and reason
This pull request brings changes from #34 and #36 as well as a few changes to make sure everything still works for all supported versions.
@simonprev I’m going to need your 👍 on this one since I had to change a few things to make tests pass.
This should close #34 and #36. Thank you @kianmeng & @martinmaillard!
🦀 Dispatch
#dispatch/elixir