Fixing spawn_test for go 1.21 #208
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haavardw
reviewed
Feb 9, 2024
spawn_test.go
Outdated
|
|
||
| "github.com/miquella/vaulted/lib" | ||
| ) | ||
|
|
||
| func TestSpawn(t *testing.T) { | ||
| spawnRefreshVar := `GOPATH="/vaulted"` | ||
| spawnRefreshVar := `GOPATH=["|']/vaulted` |
There was a problem hiding this comment.
Isn't the | wrong? ["'] should be correct? Otherwise you will also match |/valued which I don't think you want to do.
In go 1.21, `go env` changed the way it printed values go version < 1.21: ``` GOPATH="/vaulted" ... ``` go >= 1.21: ``` GOPATH='/vaulted' ... ``` Which causes `spawn_test.go` to fail, since it's looking for exactly `GOPATH="/vaulted"` in `go env`'s output. This commit updates the test to look for single quotes or double quotes, making it compatible with all versions of go.
pfgray
force-pushed
the
go_1.21_compat
branch
from
2a6c041 to
fdda0e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In go 1.21,
go envchanged the way it printed valuesgo version < 1.21:
go >= 1.21:
Which causes
spawn_test.goto fail, since it's looking for exactlyGOPATH="/vaulted"ingo env's output.This commit updates the test to look for single quotes or double quotes, making it compatible with all versions of go.