Skip to content
This repository has been archived by the owner on Oct 2, 2019. It is now read-only.

Relax assumptions in webpack:compile rake tasks #60

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pariser
Copy link

@pariser pariser commented Sep 21, 2016

  • Don't assume that ::Rails.configuration.webpack.binary specifies a webpack path relative to Rails root.
  • Don't assume that we know the exact webpack binary location (allow webpack executable to be on $PATH, in which case we no longer die with a File.exist? error).

* Don't assume that ::Rails.configuration.webpack.binary specifies
  a webpack path relative to Rails root.
* Don't assume that we know the exact webpack binary location
  (allow webpack executable to be on $PATH, in which case we no
  longer die with a File.exist? error).
@mipearson
Copy link
Owner

I like this, but it needs to support the current configuration by default so that it doesn't break for existing users.

In our configuration we don't install webpack (or webpack dev server) globally.

@juanca
Copy link

juanca commented Oct 7, 2016

If the compile script leveraged an npm task then I think this can completely be avoided? Perhaps there should be a npm run webpack:compile task which compiles with a production flag(s).

@mipearson
Copy link
Owner

I'm going to be bringing this in to an API-breaking 1.0-pre branch shortly.

The delay on this (and other) pull requests is that I've been cautious to merge anything that could break functionality for existing users.

@pariser
Copy link
Author

pariser commented Oct 26, 2016

Cool! Let me know if and how I can help with this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants