Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add export http boefje #3901

Merged
merged 10 commits into from
Dec 4, 2024
Merged

Add export http boefje #3901

merged 10 commits into from
Dec 4, 2024

Conversation

noamblitz
Copy link
Contributor

Changes

Adds a boefje that can expose OOI information to an API.
Before merging: make sure boefje only runs once!

Demo

image

QA notes

Can be tested by using https://webhook.site/

Code Checklist

  • All the commits in this PR are properly PGP-signed and verified.
  • This PR only contains functionality relevant to the issue.
  • I have written unit tests for the changes or fixes I made.
  • I have checked the documentation and made changes where necessary.
  • I have performed a self-review of my code and refactored it to the best of my abilities.
  • Tickets have been created for newly discovered issues.
  • For any non-trivial functionality, I have added integration and/or end-to-end tests.
  • I have informed others of any required .env changes files if required and changed the .env-dist accordingly.
  • I have included comments in the code to elaborate on what is not self-evident from the code itself, including references to issues and discussions online, or implicit behavior of an interface.

Checklist for code reviewers:

Copy-paste the checklist from the docs/source/templates folder into your comment.

Checklist for QA:

Copy-paste the checklist from the docs/source/templates folder into your comment.

@underdarknl
Copy link
Contributor

@noamblitz can you add a runon=["create", "update"] to the boefje's manifest?

#3879 (comment)

@noamblitz
Copy link
Contributor Author

@noamblitz can you add a runon=["create", "update"] to the boefje's manifest?

#3879 (comment)

Just add "runon": ["create", "update"] in the boefje.json?

This was referenced Nov 28, 2024
Merged
Closed
ammar92
ammar92 reviewed Dec 3, 2024
View reviewed changes
Copy link
Contributor

@ammar92 ammar92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny remark, looks good otherwise

boefjes/boefjes/plugins/kat_export_http/main.py Outdated Show resolved Hide resolved
boefjes/boefjes/plugins/kat_export_http/main.py Outdated Show resolved Hide resolved
@ammar92
Copy link
Contributor

ammar92 commented Dec 4, 2024

Refactored, QA'd with @noamblitz and tests fixed

@ammar92 ammar92 marked this pull request as ready for review December 4, 2024 15:30
@ammar92 ammar92 requested a review from a team as a code owner December 4, 2024 15:30
@ammar92 ammar92 changed the title WIP: Add export http boefje Add export http boefje Dec 4, 2024
@dekkers dekkers merged commit 1ef538f into main Dec 4, 2024
19 checks passed
@dekkers dekkers deleted the export-http-boefje branch December 4, 2024 16:22
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

jpbruinsslot added a commit that referenced this pull request Dec 11, 2024
@jpbruinsslot
Merge branch 'main' into poc/mula/combined-schedulers
c40193f 
* main: (21 commits)
  Bump django from 5.0.9 to 5.0.10 in /rocky (#3940)
  Do not let enabling plugins affect the global plugin cache (#3944)
  Fix typing in more places and configure mypy to follow imports (#3932)
  Updates CWE archive to 4.16 (#3943)
  Report flaws (#3880)
  Translations update from Hosted Weblate (#3939)
  Fix report recipe API (#3942)
  Boefje runonce functionality in scheduler (#3906)
  fix: 🔨 do not store CDN findings (#3931)
  Dont check for Locations on local Ip's. (#3894)
  add unpkg.com to disallowed hostnames in CSP (#3927)
  Update website_discovery.py (#3921)
  Add export http boefje (#3901)
  Bump python-multipart from 0.0.9 to 0.0.18 in /bytes (#3925)
  Fix layout issues on scheduled reports page (#3930)
  Create scheduled report with zero objects selectable (#3907)
  Improve the KATalogus `/plugins` endpoint performance (#3892)
  Add bgp.jsonl and bgp-meta.json to .gitignore (#3928)
  Update pre-commit and all hooks (#3923)
  add support for detecting Lame dns delegations on ip ranges (#3899)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammar92 ammar92 ammar92 left review comments

@underdarknl underdarknl underdarknl left review comments

@dekkers dekkers dekkers approved these changes

Assignees

@noamblitz noamblitz

Labels
None yet
Projects
KAT
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@noamblitz @underdarknl @ammar92 @dekkers