add more precise error when rabbitMQ cannot be reached when storing raw files #3774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Donnype
approved these changes
Nov 20, 2024
| @@ -190,6 +191,11 @@ def create_raw( | |||
| raw_data=RawDataMeta(id=raw_id, boefje_meta=raw_data.boefje_meta, mime_types=raw_data.mime_types), | |||
| ) | |||
| event_manager.publish(event) | |||
| except pika.exceptions.AMQPError as error: | |||
| logger.exception("Error sending 'new raw data' event to RabbitMQ") | |||
| raise HTTPException( | |||
There was a problem hiding this comment.
Is this something we want to expose to someone using the API?
There was a problem hiding this comment.
I'd say, yes? Its an authenticated user, and their request failed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Specifically catches the rabbitMQ errors which might occur if (even after the retries) it still cannot be reached.
The original 500 does not show the stacktrace in de logs, and as such there is no easy way for the user to know rabbitMQ might be at fault.
Issue link
Closes ...
Demo
Please add some proof in the form of screenshots or screen recordings to show (off) new functionality, if there are interesting new features for end-users.
QA notes
Please add some information for QA on how to test the newly created code.
Code Checklist
.envchanges files if required and changed the.env-distaccordingly.Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.