Do not run dh_strip_nondeterminism in Debian packaging #3674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist for QA:
What works:Workflow ran succesfully. Went through the onboarding and that also works as expected. What doesn't work:n/a Bug or feature?:n/a |
|
underdarknl
approved these changes
Oct 16, 2024
jpbruinsslot
added a commit
that referenced
this pull request
Oct 24, 2024
* main: (25 commits) Add sterr to output list (#3649) feat: ✨ add Shodan InternetDB boefje (#2615) Add search endpoint for schedules for scheduler (#3695) Fix/report naming (#3666) Add delete schedule functionality for schedules in the scheduler (#3678) Fix javascript and component template in prod environments (#3672) Fix first order dangling affirmation delete (#3682) Do not run dh_strip_nondeterminism in Debian packaging (#3674) Github action should trigger if workflow definition changes (#3680) Updated packages (#3694) Silence KATFindingType not found error in JobHandler (#3686) Add docs for xtdb analyze bits. (#3688) Fix empty vulnerability reports (#3662) Fix jsonb 'contained by' query (#3643) Add plugins to findings report (#3657) Translations update from Hosted Weblate (#3673) Update upload_raw.py (#3645) Add rocky worker service to debian packages (#3619) Fix/yielded objects (#3669) make some things look better (#3661) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
In Debian packaging dh_strip_nondeterminism is used to strip nondeterminisc information from files. This isn't useful for us, because we ship a complete virtualenv in the package, but it will run on the whole virtualenv and took up a significant amount of time when building the Debian packages.
QA notes
This shouldn't change anything inside the Debian packages. I'll manually start the test debian install workflow at https://github.com/minvws/nl-kat-coordination/actions/runs/11292153433, if that succeeds I don't think any manual QA is needed.
Checklist for code reviewers:
Copy-paste the checklist from the docs/source/templates folder into your comment.
Checklist for QA:
Copy-paste the checklist from the docs/source/templates folder into your comment.