Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greetings from Danny of WalletScrutiny.com #101

Open
xrviv opened this issue Sep 14, 2023 · 2 comments
Open

Greetings from Danny of WalletScrutiny.com #101

xrviv opened this issue Sep 14, 2023 · 2 comments

Comments

@xrviv
Copy link

xrviv commented Sep 14, 2023

Hello, this is Danny.

We scrutinize source-available bitcoin wallet projects and we're currently not able to verify your app for the following reasons:

  1. The project does not use release/tags, making finding matching versions difficult.
  2. Given this commit incremented the version from 0.2.7 to 0.2.10 with Google Play featuring version v0.2.9, we can say with certainty that reproducing the version on Google Play is impossible.

For more information about your app's status in walletscrutiny, please visit our gitlab issue page:

https://gitlab.com/walletscrutiny/walletScrutinyCom/-/issues/502

For more information about walletscrutiny.com, https://walletscrutiny.com/methodology/

The WalletScrutiny project on Gitlab: https://gitlab.com/walletscrutiny/walletScrutinyCom

The GitHub page is only a mirror.

Thank you.

@keraliss
Copy link

hi, keraliss from walletscrutiny here. i was trying to revisit the reproducability of your wallet. the version issue still persists. we have no way to know if the version on the play store and the github are the same or not, which is a huge red flag. But i tried to build the wallet anyway, and was stuck on the first step of the process. there are multiple version conflicts, react and react native version mismatch, and also there are some private repos used as dependencies - which prevents us from testing the wallet any furthur!

would be great if you can look into the issues.

@anyxem
Copy link
Contributor

anyxem commented Dec 21, 2024

Hi @keraliss ,
Thank you for pointing out these issues. I wanted to let you know that we already have a pull request in progress that updates the dependencies, which should address the version conflicts you encountered. Once it’s merged, it should make the build process smoother.
Thanks again for your feedback, and I’ll keep you updated on the progress!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants