Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate GH crashes when page timeout is set multiple times #48

Open
uuf6429 opened this issue Nov 12, 2024 · 4 comments
Open

Investigate GH crashes when page timeout is set multiple times #48

uuf6429 opened this issue Nov 12, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@uuf6429
Copy link
Member

uuf6429 commented Nov 12, 2024

While adding tests in #38, we've hit a very strange bug where setting page load timeout in combination with window tests causes crashes, but only on GitHub actions.

We've had a long investigation already, but it was inconclusive, so we ended up disabling the tests in the specific cases.

This issue is to track this problem, investigate deeper, collect information and hopefully find a solution.

@uuf6429 uuf6429 added the bug Something isn't working label Nov 12, 2024
@uuf6429
Copy link
Member Author

uuf6429 commented Jan 1, 2025

@aik099 I wonder if the crashes might have been related to php-webdriver/php-webdriver#1120.

@aik099
Copy link
Member

aik099 commented Jan 1, 2025

Have you updated our tests to avoid using the NULL timeout value as a means for resetting a timeout in a JsonWireProtocol?

Maybe we need to stop/start the Selenium session to reset timeout (I thought we were already doing that).

@uuf6429
Copy link
Member Author

uuf6429 commented Jan 1, 2025

Well at one point instead of null or not setting the timeouts, we started setting the default W3C values (e.g. 30s etc). Other than that I don't know. For now I propose waiting until php-webdriver-side is fixed then I can resume this task.

@aik099
Copy link
Member

aik099 commented Jan 1, 2025

Well at one point instead of null or not setting the timeouts, we started setting the default W3C values (e.g. 30s etc). Other than that I don't know. For now I propose waiting until php-webdriver-side is fixed then I can resume this task.

OK. I hope, that applying this fix in the above-mentioned PR (we can use it only with a new WebDriver release) would fix the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants