Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip "testDragDropOntoHiddenItself" test on Selenium 2 + Firefox #401

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Skip "testDragDropOntoHiddenItself" test on Selenium 2 + Firefox #401

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9a84262
Skip "testDragDropOntoHiddenItself" test on Selenium 2 + Firefox
aik099 Nov 11, 2024
d9ab42a
Fix for static code analyzers
aik099 Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,9 @@ jobs:
- name: Run tests
env:
SELENIUM_VERSION: ${{ matrix.selenium_version }}
DRIVER_URL: http://localhost:4444/wd/hub
WEB_FIXTURES_BROWSER: firefox
DRIVER_MACHINE_BASE_PATH: /fixtures/
run: |
vendor/bin/phpunit -v --coverage-clover=coverage.xml
Expand Down
12 changes: 12 additions & 0 deletions tests/Selenium2Config.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,18 @@ public function skipMessage($testCase, $test): ?string
return 'Checking status code is not supported.';
}

if (
'Behat\Mink\Tests\Driver\Js\JavascriptTest' === $testCase
&& 'testDragDropOntoHiddenItself' === $test
aik099 marked this conversation as resolved.
Show resolved Hide resolved
) {
$seleniumVersion = $_SERVER['SELENIUM_VERSION'] ?? null;
$browser = $_SERVER['WEB_FIXTURES_BROWSER'] ?? null;
aik099 marked this conversation as resolved.
Show resolved Hide resolved

if ($seleniumVersion && version_compare($seleniumVersion, '3.0.0', '<') && $browser === 'firefox') {
return 'The Firefox browser compatible with Selenium Server 2.x doesn\'t fully implement drag-n-drop support.';
}
}

return parent::skipMessage($testCase, $test);
}

Expand Down
Loading