From 5d8d7133cca48112c41d43f6aa357ce2edd8de96 Mon Sep 17 00:00:00 2001
From: Kate Smith <52196833+kate-49@users.noreply.github.com>
Date: Thu, 4 Jul 2024 09:44:17 +0100
Subject: [PATCH] =?UTF-8?q?sw-7186=20increase=20window=20size=20and=20remo?=
 =?UTF-8?q?ve=20hard=20coded=20heights=20that=20throw=E2=80=A6=20(#473)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

* sw-7186 increase window size and remove hard coded heights that throw console errors

* sw-7186 set to 500px for test

* Update main.scss
---
 web/assets/main.scss                                 | 4 ++++
 web/template/filters/assignee-filter.gotmpl          | 2 +-
 web/template/filters/case-type-filter.gotmpl         | 2 +-
 web/template/filters/deputy-type-filter.gotmpl       | 2 +-
 web/template/filters/ecm-filter.gotmpl               | 2 +-
 web/template/filters/status-filter.gotmpl            | 2 +-
 web/template/filters/supervision-level-filter.gotmpl | 2 +-
 web/template/filters/task-type-filter.gotmpl         | 4 ++--
 web/template/inserts/success-banner.gotmpl           | 2 +-
 9 files changed, 13 insertions(+), 9 deletions(-)

diff --git a/web/assets/main.scss b/web/assets/main.scss
index 88079b9f..7f55c77a 100644
--- a/web/assets/main.scss
+++ b/web/assets/main.scss
@@ -36,3 +36,7 @@ $moj-assets-path: "/supervision/workflow/assets/";
   color: govuk-colour("blue");
   text-decoration: underline;
 }
+
+#list-of-tasks-to-filter{
+    max-height: 500px;
+}
diff --git a/web/template/filters/assignee-filter.gotmpl b/web/template/filters/assignee-filter.gotmpl
index 138eabc7..b3861030 100644
--- a/web/template/filters/assignee-filter.gotmpl
+++ b/web/template/filters/assignee-filter.gotmpl
@@ -15,7 +15,7 @@
         </div>
       </div>
 
-      <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-assignees-to-filter" tabindex="-1" style="height: 254.333px;">
+      <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-assignees-to-filter" tabindex="-1">
         <div class="app-c-option-select__container-inner js-auto-height-inner">
           <fieldset class="govuk-fieldset" aria-label="Assigned">
             <legend class="hide">Assignees</legend>
diff --git a/web/template/filters/case-type-filter.gotmpl b/web/template/filters/case-type-filter.gotmpl
index 8497a9ef..50440ad5 100644
--- a/web/template/filters/case-type-filter.gotmpl
+++ b/web/template/filters/case-type-filter.gotmpl
@@ -18,7 +18,7 @@
       </div>
     </div>
 
-    <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-case-types-to-filter" tabindex="-1" style="height: 254.333px;">
+    <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-case-types-to-filter" tabindex="-1">
       <div class="app-c-option-select__container-inner js-auto-height-inner ">
         <fieldset class="govuk-fieldset" aria-label="Case type">
           <legend class="hide" >Case type</legend>
diff --git a/web/template/filters/deputy-type-filter.gotmpl b/web/template/filters/deputy-type-filter.gotmpl
index 327f42b2..36fea741 100644
--- a/web/template/filters/deputy-type-filter.gotmpl
+++ b/web/template/filters/deputy-type-filter.gotmpl
@@ -18,7 +18,7 @@
       </div>
     </div>
 
-    <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-deputy-types-to-filter" tabindex="-1" style="height: 254.333px;">
+    <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-deputy-types-to-filter" tabindex="-1">
       <div class="app-c-option-select__container-inner js-auto-height-inner ">
         <fieldset class="govuk-fieldset" aria-label="Deputy type">
           <legend class="hide" >Deputy type</legend>
diff --git a/web/template/filters/ecm-filter.gotmpl b/web/template/filters/ecm-filter.gotmpl
index 755c3496..b1a1864d 100644
--- a/web/template/filters/ecm-filter.gotmpl
+++ b/web/template/filters/ecm-filter.gotmpl
@@ -14,7 +14,7 @@
     </div>
   </div>
 
-  <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-ecms-to-filter" tabindex="-1" style="height: 254.333px;">
+  <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-ecms-to-filter" tabindex="-1">
     <div class="app-c-option-select__container-inner js-auto-height-inner">
       <fieldset class="govuk-fieldset" aria-label="Assigned">
         <legend class="hide">Executive Case Managers</legend>
diff --git a/web/template/filters/status-filter.gotmpl b/web/template/filters/status-filter.gotmpl
index e86c4bd0..bac388e9 100644
--- a/web/template/filters/status-filter.gotmpl
+++ b/web/template/filters/status-filter.gotmpl
@@ -15,7 +15,7 @@
     </div>
   </div>
 
-  <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-statuses-to-filter" tabindex="-1" style="height: 254.333px;">
+  <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-statuses-to-filter" tabindex="-1">
     <div class="app-c-option-select__container-inner js-auto-height-inner ">
       <fieldset class="govuk-fieldset" aria-label="Status">
         <legend class="hide" >Status</legend>
diff --git a/web/template/filters/supervision-level-filter.gotmpl b/web/template/filters/supervision-level-filter.gotmpl
index 97046633..f179995d 100644
--- a/web/template/filters/supervision-level-filter.gotmpl
+++ b/web/template/filters/supervision-level-filter.gotmpl
@@ -20,7 +20,7 @@
           </div>
         </div>
 
-        <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-supervision-levels-to-filter" tabindex="-1" style="height: 254.333px;">
+        <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-supervision-levels-to-filter" tabindex="-1">
           <div class="app-c-option-select__container-inner js-auto-height-inner ">
             <fieldset class="govuk-fieldset" aria-label="Supervision level">
               <legend class="hide" >Supervision level</legend>
diff --git a/web/template/filters/task-type-filter.gotmpl b/web/template/filters/task-type-filter.gotmpl
index f3382a05..c94a3ff9 100644
--- a/web/template/filters/task-type-filter.gotmpl
+++ b/web/template/filters/task-type-filter.gotmpl
@@ -1,7 +1,7 @@
 {{- /*gotype: github.com/ministryofjustice/opg-sirius-workflow/internal/server.FilterByTaskType*/ -}}
 {{ define "task-type-filter" }}
 
-<div class="moj-filter__options" data-filter-name="moj-filter-name-tasktype">
+<div class="moj-filter__options" data-filter-name="moj-filter-name-tasktype" id="moj-filter-name-tasktype">
 
   <div class="app-c-option-select">
     <div class="app-c-option-select__heading js-container-heading filter-toggle-button">
@@ -15,7 +15,7 @@
     </div>
   </div>
 
-  <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-tasks-to-filter" tabindex="-1" style="height: 254.333px;">
+  <div role="group" class="app-c-option-select__container js-options-container filter-inner-container hide" id="list-of-tasks-to-filter" tabindex="-1">
     <div class="app-c-option-select__container-inner js-auto-height-inner ">
       <fieldset class="govuk-fieldset" aria-label="Task type">
         <legend class="hide" >Task types</legend>
diff --git a/web/template/inserts/success-banner.gotmpl b/web/template/inserts/success-banner.gotmpl
index 9cd70ffa..1dda4d34 100644
--- a/web/template/inserts/success-banner.gotmpl
+++ b/web/template/inserts/success-banner.gotmpl
@@ -1,6 +1,6 @@
 {{ define "success-banner" }}
   <div class="moj-banner moj-banner--success" data-module="moj-banner-auto-hide">
-    <svg class="moj-banner__icon" fill="currentColor" role="presentation" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 25 25" height="25" width="25">
+    <svg class="moj-banner__icon" fill="currentColor" role="presentation" focusable="false" xmlns="http://www.w3.org/2000/svg" viewBox="0 0 25 25" width="25">
       <path d="M25,6.2L8.7,23.2L0,14.1l4-4.2l4.7,4.9L21,2L25,6.2z" />
     </svg>