Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using dependabot directories attriubute in the dependabot.yml configuration. #7053

Closed
2 tasks done
ewastempel opened this issue May 20, 2024 · 6 comments
Closed
2 tasks done
Assignees
Labels
code quality Stale technical debt This issue is either technical debt or an issue that will lead to technical debt as time goes by.

Comments

@ewastempel
Copy link
Contributor

ewastempel commented May 20, 2024

User Story

Currently the package-ecosystem configuration in the dependabot files of the MP repositories uses single directory attribute (example). The dependabot now supports directories attribute that allows for passing multiple directories in the package-ecosystem configuration.

This ticket is to update dependabot.yml with to adopt directories configuration over the directory one.

Value / Purpose

Using directories instead of directory configuration keeps the code DRY.

Additional Information

See the dependabot example for implementation, also implemented here by Analytical Platform team.

Definition of Done

  • dependabot.yml configuration in all MP repositories is updated to use directories
  • the change is tested
@ewastempel ewastempel changed the title Using dependabot directories attriubute in the dependabot.yaml configuration. Using dependabot directories attriubute in the dependabot.yml configuration. May 20, 2024
@ewastempel ewastempel added technical debt This issue is either technical debt or an issue that will lead to technical debt as time goes by. code quality labels May 20, 2024
@jacobwoffenden
Copy link
Member

@ewastempel I would proceed with caution on this 😅 our Dependabot configuration is bit buggy now, see ministryofjustice/analytical-platform#4376 and the linked issue

@markgov
Copy link
Contributor

markgov commented Jul 4, 2024

On Hold until issues resolved

Copy link
Contributor

github-actions bot commented Oct 7, 2024

This issue is stale because it has been open 90 days with no activity.

@ASTRobinson
Copy link
Contributor

I've checked the dependabot file and can confirm it's now using the directories attribute - moving to done.

@github-project-automation github-project-automation bot moved this from For Review to Done in Modernisation Platform Jan 10, 2025
@dms1981 dms1981 moved this from Done to In Progress in Modernisation Platform Jan 15, 2025
@dms1981 dms1981 reopened this Jan 15, 2025
@github-project-automation github-project-automation bot moved this from In Progress to To Do in Modernisation Platform Jan 15, 2025
@dms1981
Copy link
Contributor

dms1981 commented Jan 15, 2025

After implementing this we've run into issues. From the MP & MP Environments repo we can see errors like this:

updater | 2025/01/15 08:58:49 INFO <job_948323016> Updating integrations/github from  to 6.4.0
...
+-------------------------------------+
|    Dependencies failed to update    |
+---------------------+---------------+
| integrations/github | unknown_error |
+---------------------+---------------+

And in the AMI builds repo we can see this:

+-------------------------------+
|            Errors             |
+-------------------------------+
| dependency_file_not_parseable |
+-------------------------------+

With this in mind, I've proposed that we revert the changes in this issue and return to our original (functional) state.

@dms1981
Copy link
Contributor

dms1981 commented Jan 15, 2025

Given the issues that we saw with directories: we've chosen to revert to our previous approach here. When investigating it appeared to me that the issues were all related to the terraform ecosystem, but as that's a major tool for us then reverting this work was warranted.

@dms1981 dms1981 closed this as completed Jan 15, 2025
@github-project-automation github-project-automation bot moved this from To Do to Done in Modernisation Platform Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Stale technical debt This issue is either technical debt or an issue that will lead to technical debt as time goes by.
Projects
Status: Done
Development

No branches or pull requests

6 participants