From 5898828c832454f385db2a46a7740829a1a09090 Mon Sep 17 00:00:00 2001 From: Phil Payne Date: Thu, 18 Jan 2024 13:05:41 +0000 Subject: [PATCH] PR Amendments --- caab-api/open-api-specification.yml | 12 +++++++----- .../BaseApplicationControllerIntegrationTest.java | 2 +- .../caab/api/controller/ApplicationController.java | 4 ++-- 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/caab-api/open-api-specification.yml b/caab-api/open-api-specification.yml index 5280700..358b2fe 100644 --- a/caab-api/open-api-specification.yml +++ b/caab-api/open-api-specification.yml @@ -354,7 +354,7 @@ paths: get: tags: - applications - summary: 'Get an application''s prior authorities' + summary: 'Get an application''s cost structure' operationId: 'getApplicationCostStructure' parameters: - name: 'id' @@ -417,6 +417,7 @@ paths: /applications/{id}/linked-cases: get: tags: + - applications - linked cases summary: 'Get an application''s linked cases' operationId: 'getApplicationLinkedCases' @@ -447,6 +448,7 @@ paths: description: 'Internal server error' post: tags: + - applications - linked cases summary: 'Add a linked case to an application' operationId: 'addApplicationLinkedCase' @@ -484,8 +486,8 @@ paths: delete: tags: - linked cases - summary: 'Remove a linked case from an application' - operationId: 'removeApplicationLinkedCase' + summary: 'Remove a linked case' + operationId: 'removeLinkedCase' parameters: - name: 'linked-case-id' in: 'path' @@ -513,8 +515,8 @@ paths: patch: tags: - linked cases - summary: 'Update a linked case of an application' - operationId: 'updateApplicationLinkedCase' + summary: 'Update a linked case ' + operationId: 'updateLinkedCase' parameters: - name: 'linked-case-id' in: 'path' diff --git a/caab-service/src/integrationTest/java/uk/gov/laa/ccms/data/api/controller/BaseApplicationControllerIntegrationTest.java b/caab-service/src/integrationTest/java/uk/gov/laa/ccms/data/api/controller/BaseApplicationControllerIntegrationTest.java index cd8c6fd..498638e 100644 --- a/caab-service/src/integrationTest/java/uk/gov/laa/ccms/data/api/controller/BaseApplicationControllerIntegrationTest.java +++ b/caab-service/src/integrationTest/java/uk/gov/laa/ccms/data/api/controller/BaseApplicationControllerIntegrationTest.java @@ -413,7 +413,7 @@ public void deleteLinkedCase() { Long caseRef = 41L; Long linkedCaseRef = 2L; - applicationController.removeApplicationLinkedCase(linkedCaseRef, caabUserLoginId); + applicationController.removeLinkedCase(linkedCaseRef, caabUserLoginId); ResponseEntity> responseEntity = applicationController.getApplicationLinkedCases(caseRef); assertEquals(HttpStatus.OK, responseEntity.getStatusCode()); diff --git a/caab-service/src/main/java/uk/gov/laa/ccms/caab/api/controller/ApplicationController.java b/caab-service/src/main/java/uk/gov/laa/ccms/caab/api/controller/ApplicationController.java index 5c27d96..a7f55bf 100644 --- a/caab-service/src/main/java/uk/gov/laa/ccms/caab/api/controller/ApplicationController.java +++ b/caab-service/src/main/java/uk/gov/laa/ccms/caab/api/controller/ApplicationController.java @@ -276,7 +276,7 @@ public ResponseEntity addApplicationLinkedCase( * @return a ResponseEntity with no content */ @Override - public ResponseEntity updateApplicationLinkedCase( + public ResponseEntity updateLinkedCase( final Long linkedCaseId, final String caabUserLoginId, final LinkedCase linkedCase) { @@ -292,7 +292,7 @@ public ResponseEntity updateApplicationLinkedCase( * @return a ResponseEntity indicating the case was successfully removed */ @Override - public ResponseEntity removeApplicationLinkedCase( + public ResponseEntity removeLinkedCase( final Long linkedCaseId, final String caabUserLoginId) { linkedCaseService.removeLinkedCase(linkedCaseId);