Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞 Investigate KubernetesClient credential usage in Control Panel #6580

Open
michaeljcollinsuk opened this issue Jan 21, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@michaeljcollinsuk
Copy link
Contributor

Describe the bug.

There is a KubernetesClient wrapper class in Control Panel, that attempts use a users ID token as its auth credential when making API calls. I am not sure that this is working as intended, so we should spend some time to dig a bit deeper about:

  1. What the original intention of using a users ID token was rather than the service accounts credentials
  2. How this is intended to work and determine if this is working or not
  3. Amend the implementation as necessary

To Reproduce

  1. Run the control panel locally
  2. Update the code where the KubernetesClient is used (e.g. tool restart) and pass an arbritary string rather than a real ID token
  3. Trigger the action in the browser (e.g. tool restart)
  4. If the restart triggers successfully, this indicates the ID token being passed in the KubernetesClient is irrelevant

Expected Behaviour

No response

Additional context

No response

@michaeljcollinsuk michaeljcollinsuk added the bug Something isn't working label Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 👀 TODO
Development

No branches or pull requests

1 participant