Carts: Improve movement behaviour #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SmallJoker
force-pushed
the
carts_maintenance
branch
from
1928c6b to
a924bb1
Compare
Backported various changes from boost_cart Improved direction handling and code cleanup Smoothed-out 'end of rail' animation
SmallJoker
force-pushed
the
carts_maintenance
branch
from
a924bb1 to
5c5bb5c
Compare
appgurueu
reviewed
May 6, 2022
appgurueu
reviewed
May 6, 2022
appgurueu
approved these changes
May 8, 2022
There was a problem hiding this comment.
From a quick glance the code looks fine to me. Cart movement works fine. The horizontal direction is preferable over the current bug; ideally the cart should roll down if possible (or be rotated properly), but that should be left to a later PR after cart rotation has been cleaned up.
Wuzzy2
pushed a commit
to Wuzzy2/minetest_game
that referenced
this pull request
Jul 22, 2022
Backported various changes from boost_cart Improved direction handling and code cleanup Smoothed-out 'end of rail' animation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backported various changes from boost_cart
Improved direction handling and code cleanup
Smoothed-out 'end of rail' animation
Partial fix for #2948 - the cart is now stopping in a horizontal direction. The problem here is that the next node (after downhill turn-back) is on the same Y level as the cart, hence there's straight rail friction which makes the cart stop immediately.
This far from perfect but aimed to provide at least a little bit better experience until a bullet-proof solution is found.