Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Torches visibly "teleport" on place. #3118

Open
Kazooo100 opened this issue May 21, 2024 · 1 comment
Open

Torches visibly "teleport" on place. #3118

Kazooo100 opened this issue May 21, 2024 · 1 comment

Comments

@Kazooo100
Copy link

When you place a wall torch it renders as floor torch for a second before becoming wall torch. This is not an issue in some other games (such as mineclonia) so it is not an engine thing.

This can be fixed by adding

node_placement_prediction = "",

to mods/default/torch.lua around line 46, under sounds before on_place

@Kazooo100 Kazooo100 changed the title Torches visibly "telelport" on place. Torches visibly "teleport" on place. May 21, 2024
@appgurueu
Copy link
Contributor

There is an engine limitation in that the engine doesn't have the capability to do proper placement prediction here.

This can be fixed by adding node_placement_prediction = "",

This works, but will have players wait at least one round-trip time until they get the node on their screen. Under high lag conditions, this may be an issue. I also think that it will generally feel a bit "choppier" if there is no immediate client feedback.

I am not convinced that immediate, incorrect prediction is worse than delayed, correct placement.

If the round-trip time is insignificant, the "glitch" should only be visible for the blink of an eye.

A proper fix would have to wait for engine features (SSCSM or specific prediction features).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants