Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OPN-Arp: contribution #238

Closed
mr-manuel opened this issue Oct 24, 2024 · 7 comments
Closed

OPN-Arp: contribution #238

mr-manuel opened this issue Oct 24, 2024 · 7 comments

Comments

@mr-manuel
Copy link

Hello,

thanks for initializing this great plugin. I spend some hours to extend the plugin a bit. Are you interested in adopting the modifications? If yes, where should I upload the files? Unfortunately the opn-arp repository is still a bit empty.

opn-arp

@mimugmail
Copy link
Owner

Looks great! I uploaded the repo, just add a PR :) Thx!

@mr-manuel
Copy link
Author

Perfect, thanks. I will open a PR, once I tested it for a few days.

@mr-manuel
Copy link
Author

I now rewrote the whole plugin and nearly no original code is left. So my question is now, if it's better to create my own repository or if you can add my GitHub name and link to this plugin?

@mimugmail
Copy link
Owner

Sure, just create a new one and call it -community instead of -maxit

@mr-manuel
Copy link
Author

I opened a PR to merge it with the OPNsense official plugins, which should then be easier for users to install it: opnsense/plugins#4322

Would love to hear your opinion about it and maybe you have some further ideas/recommendations.

@mimugmail
Copy link
Owner

I didn't have a look at it yet, but since I have no merge rights over there I can't do much :)

@mr-manuel
Copy link
Author

No merge rights needed in this case :-) I have some questions/issues, maybe you know an answer to that or have a path you can lead me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants