Add local storage size limit (#379)

Signed-off-by: Edward Zeng <[email protected]> Signed-off-by: Edward Zeng <[email protected]>
milvus-io · Oct 21, 2022 · 9eff679 · 9eff679
1 parent 1090206
commit 9eff679
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 1 deletion.
diff --git a/charts/milvus/Chart.yaml b/charts/milvus/Chart.yaml
@@ -3,7 +3,7 @@ name: milvus
 appVersion: "2.1.4"
 kubeVersion: "^1.10.0-0"
 description: Milvus is an open-source vector database built to power AI applications and vector similarity search.
-version: 3.2.11
+version: 3.2.12
 keywords:
   - milvus
   - elastic

diff --git a/charts/milvus/templates/indexnode-deployment.yaml b/charts/milvus/templates/indexnode-deployment.yaml
@@ -65,6 +65,13 @@ spec:
         - name: LD_LIBRARY_PATH
           value: /milvus/tools/heaptrack/lib:/milvus/lib:/usr/lib
         {{- end }}
+        {{- if .Values.indexNode.disk.size.enabled }}
+        - name: LOCAL_STORAGE_SIZE
+          valueFrom:
+            resourceFieldRef:
+              divisor: 1Gi
+              resource: limits.ephemeral-storage
+        {{- end }}
         {{- if .Values.indexNode.extraEnv }}
           {{- toYaml .Values.indexNode.extraEnv | nindent 8 }}
         {{- end }}

diff --git a/charts/milvus/templates/querynode-deployment.yaml b/charts/milvus/templates/querynode-deployment.yaml
@@ -65,6 +65,13 @@ spec:
         - name: LD_LIBRARY_PATH
           value: /milvus/tools/heaptrack/lib:/milvus/lib:/usr/lib
         {{- end }}
+        {{- if .Values.queryNode.disk.size.enabled }}
+        - name: LOCAL_STORAGE_SIZE
+          valueFrom:
+            resourceFieldRef:
+              divisor: 1Gi
+              resource: limits.ephemeral-storage
+        {{- end }}
         {{- if .Values.queryNode.extraEnv }}
           {{- toYaml .Values.queryNode.extraEnv | nindent 8 }}
         {{- end }}

diff --git a/charts/milvus/templates/standalone-deployment.yaml b/charts/milvus/templates/standalone-deployment.yaml
@@ -98,6 +98,13 @@ spec:
         - name: LD_LIBRARY_PATH
           value: /milvus/tools/heaptrack/lib:/milvus/lib:/usr/lib
         {{- end }}
+        {{- if .Values.standalone.disk.size.enabled }}
+        - name: LOCAL_STORAGE_SIZE
+          valueFrom:
+            resourceFieldRef:
+              divisor: 1Gi
+              resource: limits.ephemeral-storage
+        {{- end }}
         {{- if .Values.standalone.extraEnv }}
           {{- toYaml .Values.standalone.extraEnv | nindent 8 }}
         {{- end }}

diff --git a/charts/milvus/values.yaml b/charts/milvus/values.yaml
@@ -272,6 +272,9 @@ quotaAndLimits:
 standalone:
   replicas: 1  # Run standalone mode with replication disabled
   resources: {}
+  # Set local storage size in resources
+  # limits:
+  #    ephemeral-storage: 100Gi
   nodeSelector: {}
   affinity: {}
   tolerations: []
@@ -282,6 +285,8 @@ standalone:
     enabled: false
   disk:
     enabled: false
+    size:
+      enabled: false  # Enable local storage size limit
   profiling:
     enabled: false  # Enable live profiling
 
@@ -399,6 +404,9 @@ queryNode:
   enabled: true
   replicas: 1
   resources: {}
+  # Set local storage size in resources
+  # limits:
+  #    ephemeral-storage: 100Gi
   nodeSelector: {}
   affinity: {}
   tolerations: []
@@ -409,8 +417,12 @@ queryNode:
     enabled: false
   disk:
     enabled: false  # Enable querynode load disk index, and search on disk index
+    size:
+      enabled: false  # Enable local storage size limit
   profiling:
     enabled: false  # Enable live profiling
+    size:
+      enabled: false  # Enable local storage size limit
 
   segcore:
     chunkRows: 1024  # The number of vectors in a chunk.
@@ -447,6 +459,9 @@ indexNode:
   enabled: true
   replicas: 1
   resources: {}
+  # Set local storage size in resources
+  # limits:
+  #    ephemeral-storage: 100Gi
   nodeSelector: {}
   affinity: {}
   tolerations: []
@@ -459,6 +474,8 @@ indexNode:
     enabled: false  # Enable live profiling
   disk:
     enabled: false  # Enable index node build disk vector index
+    size:
+      enabled: false  # Enable local storage size limit
 
   ## Specify how many index tasks can parallelly run in the same index node
   scheduler: