-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FR: filter source via get parameter #7
Comments
I think perhaps filtering responses by channels or by offering multiple endpoints is perhaps a better way... don't you think? Channels are pre-defined and static, while sources are variable and not meant to act as filters. I do think that a channel filtration parameter, however, would be appropriate. Thoughts? |
Would you use one channel for breaking news for all sources? Or name the channel e.g. "breaking news bbc". IMO latter is better, because multiple sources may report the same event |
Ultimately, channels are meant to be dynamic (currently they are hard-coded), so I think adopting an approach like 'breaking news bbc' would be appropriate. That's a little further away, though, so I'm going to leave this issue open and wait for the codebase to develop a bit more. |
That might be a good option |
E.g. librenews.io/api?source=bbc&source=cnn will return news from bbc and cnn. This would make it possible to use one api server for multiple languages with adding the parameters to the server url string in the android app
The text was updated successfully, but these errors were encountered: