From 0a247b6469b9ab2c530d5b105476b1372ccaccf1 Mon Sep 17 00:00:00 2001
From: Milan Wiedemann <milan.wiedemann@gmail.com>
Date: Fri, 22 May 2020 18:23:26 +0100
Subject: [PATCH] fix cran note

---
 NEWS.md            |  2 +-
 R/describe_sg.R    | 19 +------------------
 cran-comments.md   | 22 ++++++++++++++++++----
 man/describe_sg.Rd | 19 +------------------
 4 files changed, 21 insertions(+), 41 deletions(-)

diff --git a/NEWS.md b/NEWS.md
index 0d71302..c63c167 100644
--- a/NEWS.md
+++ b/NEWS.md
@@ -3,7 +3,7 @@
 - minor changes to integrate updates in tibble package
 
 # suddengains 0.4.3
-- Supress message about vector length from `extract_values()` in the functions `create_bysg()` and `create_byperson()`
+- Suppress message about vector length from `extract_values()` in the functions `create_bysg()` and `create_byperson()`
 - Update ggplot2 functions with "deprecated" warning message 
 - Add clearer detailed output message in `check_interval()` function
 
diff --git a/R/describe_sg.R b/R/describe_sg.R
index 920a7e9..e72c927 100644
--- a/R/describe_sg.R
+++ b/R/describe_sg.R
@@ -1,6 +1,6 @@
 #' Show descriptives for the sudden gains datasets
 #'
-#' Some numbers (percentages) will be different depending which form of data set (bysg vs. byperson) is selected, because if multiple gains in bysg only one will be selected for further analyses.
+#' Descriptives might differ between the bysg and byperson data sets depending on whether multiple gains are present.
 #' @param data A \code{bysg} or \code{byperson} dataset created using the function \code{\link{create_bysg}} or \code{\link{create_byperson}}.
 #' @param sg_data_structure String, indicating whether the input data is a \code{bysg} or \code{byperson} dataset.
 #' @return A list, showing basic descriptive statistics for sudden gains within the dataset specified.
@@ -34,23 +34,6 @@
 #' # Describe bysg dataset
 #' describe_sg(data = bysg,
 #'             sg_data_structure = "bysg")
-#'
-#' # Create byperson dataset
-#' byperson_first <- create_byperson(data = sgdata,
-#'                                   sg_crit1_cutoff = 7,
-#'                                   id_var_name = "id",
-#'                                   tx_start_var_name = "bdi_s1",
-#'                                   tx_end_var_name = "bdi_s12",
-#'                                   sg_var_list = c("bdi_s1", "bdi_s2", "bdi_s3",
-#'                                                   "bdi_s4", "bdi_s5", "bdi_s6",
-#'                                                   "bdi_s7", "bdi_s8", "bdi_s9",
-#'                                                   "bdi_s10", "bdi_s11", "bdi_s12"),
-#'                                   sg_measure_name = "bdi",
-#'                                   multiple_sg_select = "first")
-#'
-#' # Describe byperson dataset
-#' describe_sg(data = byperson_first,
-#'             sg_data_structure = "byperson")
 
 describe_sg <- function(data, sg_data_structure = c("bysg", "byperson")) {
 
diff --git a/cran-comments.md b/cran-comments.md
index 5905c42..21a3dc1 100644
--- a/cran-comments.md
+++ b/cran-comments.md
@@ -1,19 +1,33 @@
 # Test environments
 ## local 
-* macOS Mojave 10.14.6
-* R version 3.6.1 (2019-07-05)
+* macOS Mojave 10.15.4
+* R version 4.0.0 (2020-04-24) -- "Arbor Day"
 
 ## R CMD check results
 * There were no ERRORs or WARNINGs, or NOTES 
 
 ## travis-ci
-* R version 3.6.2 (2017-01-27)
+* R version 4.0.0 (2020-04-24)
 * Platform: x86_64-pc-linux-gnu (64-bit)
 * Running under: Ubuntu 16.04.6 LTS
 * passing
 
 ## ci.appveyor
-* R version 3.6.3 Patched (2020-02-29 r77919)
+* R version 4.0.0 Patched (2020-05-18 r78487)
 * Platform: x86_64-w64-mingw32/x64 (64-bit)
 * Running under: Windows Server 2012 R2 x64 (build 9600)
 * passing
+
+## win-builder R-release
+* using R version 4.0.0 (2020-04-24)
+* using platform: x86_64-w64-mingw32 (64-bit)
+* 1 Note
+
+## win-builder R-devel
+* using R Under development (unstable) (2020-05-19 r78492)
+* using platform: x86_64-w64-mingw32 (64-bit)
+
+## Resubmission
+This is a resubmission.
+I have shortened the examples from the describe_sg() function.
+This function should no longer exceed the time limit.
diff --git a/man/describe_sg.Rd b/man/describe_sg.Rd
index 218629b..b106466 100644
--- a/man/describe_sg.Rd
+++ b/man/describe_sg.Rd
@@ -29,7 +29,7 @@ The list includes values for:
     }
 }
 \description{
-Some numbers (percentages) will be different depending which form of data set (bysg vs. byperson) is selected, because if multiple gains in bysg only one will be selected for further analyses.
+Descriptives might differ between the bysg and byperson data sets depending on whether multiple gains are present.
 }
 \examples{
 # Create bysg dataset
@@ -47,21 +47,4 @@ bysg <- create_bysg(data = sgdata,
 # Describe bysg dataset
 describe_sg(data = bysg,
             sg_data_structure = "bysg")
-
-# Create byperson dataset
-byperson_first <- create_byperson(data = sgdata,
-                                  sg_crit1_cutoff = 7,
-                                  id_var_name = "id",
-                                  tx_start_var_name = "bdi_s1",
-                                  tx_end_var_name = "bdi_s12",
-                                  sg_var_list = c("bdi_s1", "bdi_s2", "bdi_s3",
-                                                  "bdi_s4", "bdi_s5", "bdi_s6",
-                                                  "bdi_s7", "bdi_s8", "bdi_s9",
-                                                  "bdi_s10", "bdi_s11", "bdi_s12"),
-                                  sg_measure_name = "bdi",
-                                  multiple_sg_select = "first")
-
-# Describe byperson dataset
-describe_sg(data = byperson_first,
-            sg_data_structure = "byperson")
 }