Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add all Contributors to Changelog #1337

Closed
Freezor opened this issue Jun 14, 2024 · 9 comments
Closed

Add all Contributors to Changelog #1337

Freezor opened this issue Jun 14, 2024 · 9 comments

Comments

@Freezor
Copy link
Contributor

Freezor commented Jun 14, 2024

Hi maybe this is a new feature request, but I want to add all contributors to a changelog.
I would imagine something like #{{CONTRIBUTORS}}

It should then be usable like this:

"template": "# Changelog\n\n#{{CHANGELOG}}\n\n#{{UNCATEGORIZED}}\n\n## Contributors\n\n#{{CONTRIBUTORS}}",

Is this planned or possible?

@mikepenz
Copy link
Owner

Please see the open issue: #940

So far I have not identified: This depends on the availability of a respective endpoint retrieving contribution information.
Happy to take PR proposals or suggestions to properly get this added

@mikepenz
Copy link
Owner

mikepenz commented Jun 14, 2024

To be fair it should be easier to get the contributors of this release only compared to a new contributors template

@Freezor
Copy link
Contributor Author

Freezor commented Jun 15, 2024

Fair enough. I will close this, as I see it as a duplicate. I see if I can support you there @mikepenz thanks

@Freezor Freezor closed this as completed Jun 15, 2024
@mikepenz
Copy link
Owner

It might be slightly different so feel free to keep it open. I didn't realize initially that you meant to have contributors of this one release.

For this it should be possible to combine found GitHub user names associated with all collected PRs

@Freezor
Copy link
Contributor Author

Freezor commented Jun 20, 2024

I'll test it out. thanks

@mikepenz
Copy link
Owner

It's certainly only partially what you have in mind. as yours would also cover contributors hidden in the commit chain.

@Freezor
Copy link
Contributor Author

Freezor commented Jun 22, 2024

Hi. so for now it creates All of the contributors, as I tested your preview @v5.0.0-a04 and the changes of #1341
If I got time later on, if it is easy to check only unique people.
As you can see in this test (https://github.com/Freezor/aasx-server/releases/tag/v0.3.1.111-aasV3-alpha-latest) it adds my username for each commit/PR.

@mikepenz
Copy link
Owner

Good catch. Will look into improving this one

@mikepenz
Copy link
Owner

updated the develop branch to enhance that.

@mikepenz mikepenz closed this as completed Nov 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants