-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix YOLOX #1739
Fix YOLOX #1739
Conversation
Strange thing, if I run this code, everything is just working without fails UPD: Somehow syntax error has been ignored, no problem... |
@mikel-brostrom I think now we need to add YOLOX module to requirements 😶 |
You have to call this: boxmot/tracking/detectors/__init__.py Line 9 in 755cb4d
For the correct pkg installation |
Ok, I'll try to find workaround. IMO it is better to add required packages to requirements instead of installing it on the fly after installing everything else, but no problem 🙂 |
I agree, but the right strategy has to be imported anyways. So the pkg install I can fix after this merge 🚀 |
You can use this for reference: Lines 90 to 98 in 755cb4d
This is how it worked previously with |
Yeah, it was not hard to change, but harder to find a way how to change it better to avoid problems in future. Since |
This PR should also close #1740 |
Looks good! 😄 |
This PR fixes known problems with YOLOX.
(MOTA, IDF1)
is(87.0, 80.1)
, reproduced results are(87.1, 79.9)
.Command for reproduce:
imgsz
assignment for Ultralytics/YOLOX if parameter is not passedis_ultralytics_model
function to make it simple and without creatingul_models
duplicates, which could lead to errors in future.This PR can solve the following Issues:
#1600
#1663
#1422