Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/openid client config node v20 22 #10

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Feature/openid client config node v20 22 #10

wants to merge 21 commits into from

Conversation

abroa01
Copy link
Collaborator

@abroa01 abroa01 commented Nov 21, 2024

  • Created the openid version of the webchart-oauth-example.
  • Made a video showing the flow of the application and uploaded on YouTube https://youtu.be/jqhS8GgddO4
  • changed the package.json file to
    • handle both commonJS as well as ES modules
    • change the start and test script to handle and give user an option to run either the default app (webchart-oauth-example.js i.e., that uses simple Oauth) or OpenID app (webchart-example_openid.mjs i.e., that uses new Openid code)
  • created another puppeteer-test_openid.js to test the webchart-example_openid.mjs
  • Removed the v18.x from the node-version arrays in the GitHub workflows ( Check the issue raised here. -
    Fixing the crypto library issue in version v18.x from the GitHub workflow  #9

wreiske and others added 21 commits October 8, 2024 11:43
@wreiske
Refactor code for improved robustness and modern JavaScript standards
8ea2209 
- Replaced `var` with `const` and `let` for proper variable scoping.
- Switched to ES6 module syntax and used destructuring in imports.
- Simplified control flow by using early returns instead of `else if` chains.
- Wrapped server logic in `try-catch` blocks to handle unexpected errors.
- Added JSDoc comments to document functions and enhance readability.
- Utilized the `URL` module for reliable URL parsing instead of string manipulation.
- Improved logging consistency using `console.error` for errors and `console.log` for standard logs.
@abroa01
webchart-oauth-example using openid /.well-lnown/configuration
b355bf3
@abroa01
Updated the Youtube vide link in the puppeteer file
3b736b2
@abroa01
Merge branch 'main' into feature/openid-client-config
a5a8945
@abroa01
Update node.js.yml
5a7553b
@abroa01
Update package.json
e72af6e
@abroa01
Update node.js.yml
2911fd2
@abroa01
Update puppeteer-test_openid.js
8f5943a
@abroa01
Update puppeteer-test.js
d2f5b20
@abroa01
Update puppeteer-test.js
a25cad3
@abroa01
Update puppeteer-test_openid.js
c11b7f5
@abroa01
Update puppeteer-test.js
8e65cf2
@abroa01
Update puppeteer-test_openid.js
2edd134
@abroa01
Update puppeteer-test.js
15bc839
@abroa01
Update README.md
3fba23f
@abroa01
Update webchart-example_openid.mjs
2e4ab96 
Updated the client id and hardcoded it
@abroa01
Updated package.json and removed the redundant libs
bc8ace0
@abroa01
Manually updating the clientID
7d37c02
@abroa01
Added crypto in devDep
0ed7492
@abroa01
removed crypto from devDep
561a24a
@abroa01
Update node.js.yml
6f5e07a
@abroa01 abroa01 self-assigned this Nov 21, 2024
@abroa01 abroa01 mentioned this pull request Nov 25, 2024
Open
@abroa01 abroa01 linked an issue Nov 25, 2024 that may be closed by this pull request
Make a version that uses .well-known/openid-configuration #1
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@horner horner Awaiting requested review from horner

@greenskeleton greenskeleton Awaiting requested review from greenskeleton

Assignees

@abroa01 abroa01

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make a version that uses .well-known/openid-configuration
2 participants
@abroa01 @wreiske