From 1fceb5c195bc16e341132f19b3ceb45732402acb Mon Sep 17 00:00:00 2001 From: Faith Kangai Date: Wed, 19 Jun 2024 15:32:58 +0300 Subject: [PATCH 1/5] Remove label status:waiting for author feedback if issue is closed --- .github/policies/resourceManagement.yml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/policies/resourceManagement.yml b/.github/policies/resourceManagement.yml index 9052cccebf8..964d0905565 100644 --- a/.github/policies/resourceManagement.yml +++ b/.github/policies/resourceManagement.yml @@ -1,4 +1,3 @@ -id: name: GitOps.PullRequestIssueManagement description: GitOps.PullRequestIssueManagement primitive owner: @@ -94,6 +93,16 @@ configuration: then: - addLabel: label: 'ToTriage' + - if: + - payloadType: Issues + - isAction: + action: Closed + - hasLabel: + label: 'status:waiting-for-author-feedback' + then: + - removeLabel: + label: 'status:waiting-for-author-feedback' + description: - if: - payloadType: Issue_Comment - isAction: From eee8dc916b53d002e69d87fff05361f8fcd6e340 Mon Sep 17 00:00:00 2001 From: Faith Kangai Date: Wed, 19 Jun 2024 15:49:03 +0300 Subject: [PATCH 2/5] remove dot separator from name value --- .github/policies/resourceManagement.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/policies/resourceManagement.yml b/.github/policies/resourceManagement.yml index 964d0905565..f13e489f3d2 100644 --- a/.github/policies/resourceManagement.yml +++ b/.github/policies/resourceManagement.yml @@ -1,4 +1,4 @@ -name: GitOps.PullRequestIssueManagement +name: GitOpsPullRequestIssueManagement description: GitOps.PullRequestIssueManagement primitive owner: resource: repository From f43bfdb98bcf0c542339a8f30a2b02ab7a985dec Mon Sep 17 00:00:00 2001 From: Faith Kangai Date: Thu, 20 Jun 2024 13:29:55 +0300 Subject: [PATCH 3/5] reset changes and see if validation error persists --- .github/policies/resourceManagement.yml | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/.github/policies/resourceManagement.yml b/.github/policies/resourceManagement.yml index f13e489f3d2..9052cccebf8 100644 --- a/.github/policies/resourceManagement.yml +++ b/.github/policies/resourceManagement.yml @@ -1,4 +1,5 @@ -name: GitOpsPullRequestIssueManagement +id: +name: GitOps.PullRequestIssueManagement description: GitOps.PullRequestIssueManagement primitive owner: resource: repository @@ -93,16 +94,6 @@ configuration: then: - addLabel: label: 'ToTriage' - - if: - - payloadType: Issues - - isAction: - action: Closed - - hasLabel: - label: 'status:waiting-for-author-feedback' - then: - - removeLabel: - label: 'status:waiting-for-author-feedback' - description: - if: - payloadType: Issue_Comment - isAction: From 1e875fd2747d4f50a936dee33c47800c0c079fff Mon Sep 17 00:00:00 2001 From: Faith Kangai Date: Thu, 20 Jun 2024 13:32:10 +0300 Subject: [PATCH 4/5] Minor modification to revert --- .github/policies/resourceManagement.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/policies/resourceManagement.yml b/.github/policies/resourceManagement.yml index 9052cccebf8..cb7565e2780 100644 --- a/.github/policies/resourceManagement.yml +++ b/.github/policies/resourceManagement.yml @@ -16,7 +16,7 @@ configuration: - isIssue - isOpen - hasLabel: - label: 'status:waiting-for-author-feedback' + label: 'status:waiting-for-author-feed' - hasLabel: label: 'Status: No Recent Activity' - noActivitySince: From 3fb2e69cadfd843d2d3fc07d70a615135cf4982e Mon Sep 17 00:00:00 2001 From: Faith Kangai Date: Thu, 20 Jun 2024 13:36:14 +0300 Subject: [PATCH 5/5] Readd requisite check --- .github/policies/resourceManagement.yml | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/.github/policies/resourceManagement.yml b/.github/policies/resourceManagement.yml index cb7565e2780..fade37d3052 100644 --- a/.github/policies/resourceManagement.yml +++ b/.github/policies/resourceManagement.yml @@ -16,7 +16,7 @@ configuration: - isIssue - isOpen - hasLabel: - label: 'status:waiting-for-author-feed' + label: 'status:waiting-for-author-feedback' - hasLabel: label: 'Status: No Recent Activity' - noActivitySince: @@ -119,6 +119,16 @@ configuration: - removeLabel: label: 'Status: No Recent Activity' description: + - if: + - payloadType: Issues + - isAction: + action: Closed + - hasLabel: + label: 'status:waiting-for-author-feedback' + then: + - removeLabel: + label: 'status:waiting-for-author-feedback' + description: - if: - payloadType: Issue_Comment - activitySenderHasAssociation: