From 10ab5ac46f3d57dfe6c078ab524f90399ea7e63c Mon Sep 17 00:00:00 2001
From: Andrew Omondi <andrew.omondi@microsoft.com>
Date: Mon, 14 Oct 2024 15:49:00 +0300
Subject: [PATCH] resolve conflicts and cater for edge cases

---
 transforms/csdl/preprocess_csdl.xsl             | 12 ++++++++++++
 transforms/csdl/preprocess_csdl_test_input.xml  |  5 +++++
 transforms/csdl/preprocess_csdl_test_output.xml | 15 +++++++++++++++
 3 files changed, 32 insertions(+)

diff --git a/transforms/csdl/preprocess_csdl.xsl b/transforms/csdl/preprocess_csdl.xsl
index 574bf273..4cd8cc55 100644
--- a/transforms/csdl/preprocess_csdl.xsl
+++ b/transforms/csdl/preprocess_csdl.xsl
@@ -975,6 +975,18 @@
             </xsl:call-template>
         </xsl:copy>
     </xsl:template>
+    <!-- Add paths for user authentication requirements by adding annotations to read and update the complex property-->
+    <xsl:template match="edm:Schema[@Namespace='microsoft.graph']/edm:EntityType[@Name='authentication']/edm:Property[@Name='requirements']">
+        <xsl:copy>
+            <xsl:apply-templates select="@* | node()"/>
+            <xsl:call-template name="ReadRestrictionsTemplate">
+                <xsl:with-param name="readable">true</xsl:with-param>
+            </xsl:call-template>
+            <xsl:call-template name="UpdateRestrictionsTemplate">
+                <xsl:with-param name="updatable">true</xsl:with-param>
+            </xsl:call-template>
+        </xsl:copy>
+    </xsl:template>
     <!-- Add paths for user serviceProvisioningErrors by adding annotations to read complex property-->
     <xsl:template match="edm:Schema[@Namespace='microsoft.graph']/edm:EntityType[@Name='user']/edm:Property[@Name='serviceProvisioningErrors']|
                          edm:Schema[@Namespace='microsoft.graph']/edm:EntityType[@Name='group']/edm:Property[@Name='serviceProvisioningErrors']|
diff --git a/transforms/csdl/preprocess_csdl_test_input.xml b/transforms/csdl/preprocess_csdl_test_input.xml
index f129d444..f092d636 100644
--- a/transforms/csdl/preprocess_csdl_test_input.xml
+++ b/transforms/csdl/preprocess_csdl_test_input.xml
@@ -131,6 +131,11 @@
                     <Annotation Term="Org.OData.Core.V1.Description" String="The conditions representing the context of the authentication request that will be used to decide whether the events policy will be invoked." />
                 </Property>                
             </EntityType>
+            <EntityType Name="authentication" BaseType="graph.entity" Abstract="true" OpenType="true">
+                <Property Name="requirements" Type="graph.strongAuthenticationRequirements">
+                    <Annotation Term="Org.OData.Core.V1.Description" String="The settings and preferences for per-user Microsoft Entra multifactor authentication." />
+                </Property>                
+            </EntityType>
             <ComplexType Name="onAttributeCollectionExternalUsersSelfServiceSignUp" BaseType="graph.onAttributeCollectionHandler">
                 <NavigationProperty Name="attributes" Type="Collection(graph.identityUserFlowAttribute)" />
             </ComplexType>
diff --git a/transforms/csdl/preprocess_csdl_test_output.xml b/transforms/csdl/preprocess_csdl_test_output.xml
index 870390b1..89881c6c 100644
--- a/transforms/csdl/preprocess_csdl_test_output.xml
+++ b/transforms/csdl/preprocess_csdl_test_output.xml
@@ -586,6 +586,21 @@
           <Annotation Term="Org.OData.Core.V1.Description" String="The conditions representing the context of the authentication request that will be used to decide whether the events policy will be invoked." />
         </Property>
       </EntityType>
+      <EntityType Name="authentication" BaseType="graph.entity" Abstract="true" OpenType="true">
+        <Property Name="requirements" Type="graph.strongAuthenticationRequirements">
+          <Annotation Term="Org.OData.Core.V1.Description" String="The settings and preferences for per-user Microsoft Entra multifactor authentication." />
+          <Annotation Term="Org.OData.Capabilities.V1.ReadRestrictions">
+            <Record>
+              <PropertyValue Property="Readable" Bool="true" />
+            </Record>
+          </Annotation>
+          <Annotation Term="Org.OData.Capabilities.V1.UpdateRestrictions">
+            <Record>
+              <PropertyValue Property="Updatable" Bool="true" />
+            </Record>
+          </Annotation>
+        </Property>
+      </EntityType>
       <ComplexType Name="onAttributeCollectionExternalUsersSelfServiceSignUp" BaseType="graph.onAttributeCollectionHandler">
         <NavigationProperty Name="attributes" Type="Collection(graph.identityUserFlowAttribute)">
           <Annotation Term="Org.OData.Capabilities.V1.NavigationRestrictions">