Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use prebuilt gnullvm target #3007

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Use prebuilt gnullvm target #3007

merged 1 commit into from
Apr 23, 2024

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented Apr 20, 2024

With rust-lang/rust#121712 merged we can drop -Z build-std workaround.

@mati865
Copy link
Contributor Author

mati865 commented Apr 20, 2024

I think it will work when new nightly is published and CI is retried.

.github/workflows/cross.yml Outdated Show resolved Hide resolved
@mati865
Copy link
Contributor Author

mati865 commented Apr 21, 2024

Blocked on rust-lang/rust#124229

@jeremyd2019
Copy link
Contributor

I was hoping it would reduce the need for special-case steps, like for instance the Test and Test gnullvm steps are now the same. Note that llvm-mingw does also ship a mac toolchain, so theoretically could install that and get rid of more special if checks for ubuntu...

@mati865
Copy link
Contributor Author

mati865 commented Apr 21, 2024

I've experimented with replacing duplicates with more complicated if conditions but it's not that easy. I think the best way to handle it is to leave duplicates until 13 June when current nightly will become stable.

Note that llvm-mingw does also ship a mac toolchain, so theoretically could install that and get rid of more special if checks for ubuntu...

I was wondering whether it would be beneficial to add it but I don't see much value in mac builds (windows -> windows-gnullvm could me more useful tough).

@mati865 mati865 marked this pull request as ready for review April 22, 2024 15:15
@mati865
Copy link
Contributor Author

mati865 commented Apr 22, 2024

Marked as ready to review as the CI should pass with today's nightly.

@kennykerr kennykerr merged commit f850dcb into microsoft:master Apr 23, 2024
71 checks passed
@mati865 mati865 deleted the patch-1 branch April 23, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants