Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up doc testing #3204

Closed
kennykerr opened this issue Aug 15, 2024 · 0 comments · Fixed by #3205
Closed

Clean up doc testing #3204

kennykerr opened this issue Aug 15, 2024 · 0 comments · Fixed by #3205

Comments

@kennykerr
Copy link
Collaborator

Just playing around with it and it looks good for most crates but this point for the windows and windows-sys crates seems problematic as I don't see how this would ever be the case in practice so I'm wondering what it's even for. Is it just to test the readme? test_readme already does that.

Oh, I didn't see that test. Then the doctests I added to CI can be removed (since there aren't any doctests outside the readmes).

Originally posted by @Nerixyz in #3202 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cleanup doc testing Nerixyz/windows-rs
1 participant
@kennykerr