LocalFree returns error on success

[TimMisiak]

Summary

Seems like LocalFree has a swapped error/success condition.

Docs say "If the function succeeds, the return value is NULL."

Code for LocalFree has:

#[inline]
pub unsafe fn LocalFree<P0>(hmem: P0) -> ::windows_core::Result<HLOCAL>
where
    P0: ::windows_core::IntoParam<HLOCAL>,
{
    ::windows_targets::link!("kernel32.dll" "system" fn LocalFree(hmem : HLOCAL) -> HLOCAL);
    let result__ = LocalFree(hmem.into_param().abi());
    (!result__.is_invalid()).then(|| result__).ok_or_else(::windows_core::Error::from_win32)
}

And is_invalid for HLOCAL checks for is_null.

Crate manifest

No response

Crate code

No response

[kennykerr]

See microsoft/win32metadata#1557