Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with the dwreadflags parameter of the ReadEventLog function #2028

Open
vitoway opened this issue Nov 27, 2024 · 1 comment · May be fixed by #2040
Open

Problem with the dwreadflags parameter of the ReadEventLog function #2028

vitoway opened this issue Nov 27, 2024 · 1 comment · May be fixed by #2040
Assignees
@mikebattista
Labels
enhancement New feature or request

Comments

@vitoway
Copy link

vitoway commented Nov 27, 2024

Suggestion

ReadEventLog should accept a parameter like EVENTLOG_SEQUENTIAL_READ | EVENTLOG_BACKWARDS_READ, but the current code does not seem to be able to achieve this.
https://github.com/microsoft/windows-rs/blob/d41381de6f3b10f008b30d81e35f046124ccb75d/crates/libs/windows/src/Windows/Win32/System/SystemServices/mod.rs#L365
https://github.com/microsoft/windows-rs/blob/d41381de6f3b10f008b30d81e35f046124ccb75d/crates/libs/windows/src/Windows/Win32/System/EventLog/mod.rs#L493
@vitoway vitoway added the enhancement New feature or request label Nov 27, 2024
@kennykerr
Copy link
Contributor

Looks like some of the flags for this API are not all grouped in READ_EVENT_LOG_READ_FLAGS and the enumeration doesn't have the Flags attribute.

I'll transfer to the Win32 metadata repo for consideration.

@kennykerr kennykerr transferred this issue from microsoft/windows-rs Nov 27, 2024
@mikebattista mikebattista self-assigned this Dec 3, 2024
mikebattista added a commit that referenced this issue Dec 3, 2024
@mikebattista
Problem with the dwreadflags parameter of the ReadEventLog function. F…
f11f8d6 
…ixed #2028.
@mikebattista mikebattista linked a pull request Dec 9, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mikebattista mikebattista

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Problem with the dwreadflags parameter of the ReadEventLog function microsoft/win32metadata
3 participants
@kennykerr @mikebattista @vitoway