-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update how the Python "extension pack" is published #235854
Comments
This comment was marked as off-topic.
This comment was marked as off-topic.
Still, if Pylance is installed as part of installing Python, then Python is an extension pack + an extension, and should at least indicate this by a |
Hi! The reason we do not have it as an extension pack (nor do we have it listed as dependencies) is because the python debugger and pylance are optional dependencies and this is something that currently the marketplace does not support. Thanks |
Hi there! As Eleanor mentioned, the Python extension is not an official "Extension Pack", as an extension pack is a collection of many extensions and the Python extension can work as a standalone extension. We use the "extension pack" mechanism as a workaround to automatically install Pylance and the Python Debugger extensions but also allowing them to be optional dependencies, i.e. to be uninstalled (if they were added as Dependencies like in the Ruff example, they wouldn't be optional). @isidorn do you know if there're any updates that would allow us to better solve this problem? I think it'd help at lot if the number of installed extensions (in our case, optional dependencies) were displayed as a banner on the extensions view, without requiring the Python extension to be an "official extension pack" Also to clarify @rootsmusic comment:
The Python Debugger extension will continue being installed as part of the Python extension, what is going to be removed is the the built-in debugger code that still exists in the Python extension. |
@luabud @eleanorjboyd ok, so I understand the situation as a workaround due to missing functionality in VS Code and handling of extension pack and optional dependencies. @luabud you are correct in that the main gripe I have is that it actually installs 3 extensions, when there is no indication of this, and if the problem lies in the VS Code repo and inability to help in your scenario, is there an upstream issue to solve this? My second question is, how come you do not instead publish an actual extension pack, with all these three included? Ideally though I think a cool idea for VS Code to fix would be that an extension pack can mark some dependencies as optional. When a user clicks to install such an extension pack, a popup (or similar) shows where the optional dependencies have check boxes, but can be deselected (whereas mandatory cannot be deselected). Of course, this is still an upstream issue. |
We closed this issue because we don't plan to address it in the foreseeable future. If you disagree and feel that this issue is crucial: we are happy to listen and to reconsider. If you wonder what we are up to, please see our roadmap and issue reporting guidelines. Thanks for your understanding, and happy coding! |
I am not 100% sure this is a proper feature request, or if it is even a bug, but I wanted to report it as an inconsistency I see.
The Remote Development extension pack is presented just as that, an Extension Pack. It contains only 4 extensions, and when you install this you can see in the extension view the
4
icon that it contains 4 extensions.But for the Python extension, it is presented as a normal extension in addition to an extension pack. This means it installs Python + two other extensions. This is not visible with an icon such as for the Remote Development extension pack. Also I would recon that Python then should maybe rather be presented as a pure extension pack as the Remote Development?
Compare with e.g. Ruff that insted has dependencies. I would recon that if Python requires Pylance and Python Debugger, it would be better to have them as dependencies. If they are not required, we are back to the above scenario if it better being an extension pack since it then clearly indicates it will install more than just the main Python extension.
The text was updated successfully, but these errors were encountered: