Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for phpdoc tag @used-by #227717

Closed
alexkuc opened this issue Sep 5, 2024 · 1 comment
Closed

Add support for phpdoc tag @used-by #227717

alexkuc opened this issue Sep 5, 2024 · 1 comment
Assignees
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@alexkuc
Copy link

alexkuc commented Sep 5, 2024

This is in reference to the built-in extension called "PHP Language Basics".

I see there is support for tag @uses but there is no support for @used-by even though both are valid phpdoc tags.

As a result, tag @used-by does not get highlighting and is not included in the preview of the function:

/**
 * @uses empty() Just a test
 * @used-by anotherFunction() Just a description
 * @return void 
 */
function sample() {
  empty(123);
}

image

image

Source code links:

  • "match": "(?x)\n@\n(\n api|abstract|author|category|copyright|example|global|inherit[Dd]oc|internal|\n license|link|method|property(-(read|write))?|package|param|return|see|since|source|\n static|subpackage|throws|todo|var|version|uses|deprecated|final|ignore\n)\\b",
  • "match": "(?i)\\b(spl_(classes|object_hash|autoload(_(call|unregister|extensions|functions|register))?)|class_(implements|uses|parents)|iterator_(count|to_array|apply))\\b",
@vs-code-engineering vs-code-engineering bot added the stale Issues that have not been triaged in an appropriate amount of time label Sep 12, 2024
@dbaeumer dbaeumer assigned alexr00 and unassigned dbaeumer and justschen Sep 13, 2024
@dbaeumer dbaeumer removed triage-needed stale Issues that have not been triaged in an appropriate amount of time labels Sep 13, 2024
@alexr00
Copy link
Member

alexr00 commented Sep 13, 2024

Moved to the repo that we get our PHP grammar from: KapitanOczywisty/language-php#19

@alexr00 alexr00 closed this as completed Sep 13, 2024
@alexr00 alexr00 added grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream labels Sep 13, 2024
@vs-code-engineering vs-code-engineering bot locked and limited conversation to collaborators Oct 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

4 participants