Syntax highlighting fails for DNF in PHP docblocks

[jameswatts]

Type: Bug

The syntax highlighting in docblocks for PHP code fails when a parameter has DNF in the type declaration, for example:

/**
 * An example function.
 * @param string $a The first argument.
 * @param ClassA|(ClassB&ClassC) $b The second argument.
 * @param int $c The third argument.
 * @return void
 */
function example(string $a, ClassA|(ClassB&ClassC) $b, int $c) {
  // no-op
}

In this case, text after ClassA|(ClassB&ClassC) continues to be highlighted as if it continues as the type declaration, until the end of the docblock.

Related links:

• https://php.watch/versions/8.2/dnf-types
• https://wiki.php.net/rfc/dnf_types
• https://www.php.net/manual/en/language.types.declarations.php
• https://en.wikipedia.org/wiki/Disjunctive_normal_form

VS Code version: Code 1.88.0 (5c3e652, 2024-04-03T13:26:18.741Z)
OS version: Windows_NT x64 10.0.19045
Modes:

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	undefined
Memory (System)	15.89GB (4.45GB free)
Process Argv	--crash-reporter-id b7052d12-55ed-4ece-8a88-14326b3ee93e
Screen Reader	no
VM	0%

Extensions (13)

Extension	Author (truncated)	Version
vscode-intelephense-client	bme	1.10.4
composer-php-vscode	DEV	1.45.15192
copilot	Git	1.178.0
copilot-chat	Git	0.14.0
vscode-pull-request-github	Git	0.86.0
vscode-docker	ms-	1.29.0
remote-containers	ms-	0.354.0
remote-wsl	ms-	0.88.0
vscode-speech	ms-	0.8.0
vscode-php-codesniffer	obl	3.0.1
vscode-thunder-client	ran	2.20.3
code-spell-checker	str	3.0.1
php-debug	xde	1.34.0

A/B Experiments

vsliv368:30146709
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593:30376534
py29gd2263:30899288
c4g48928:30535728
azure-dev_surveyone:30548225
a9j8j154:30646983
962ge761:30959799
pythongtdpath:30769146
welcomedialog:30910333
pythonidxpt:30866567
pythonnoceb:30805159
asynctok:30898717
pythontestfixt:30902429
pythonregdiag2:30936856
pyreplss1:30897532
pythonmypyd1:30879173
pythoncet0:30885854
h48ei257:31000450
pythontbext0:30879054
accentitlementsc:30995553
dsvsc016:30899300
dsvsc017:30899301
dsvsc018:30899302
cppperfnew:31000557
d34g3935:30971562
fegfb526:30981948
bg6jg535:30979843
ccp1r6:30993540
dsvsc020:30976470
pythonait:31006305
gee8j676:31009558
dsvsc021:30996838
g1icg217:30999571

[jameswatts]

Adding a screenshot as a reference:

[alexr00]

I can repro. Moved to KapitanOczywisty/language-php#16, which is where we get our PHP syntax highlighting grammar from.