Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking change in vscode://file paths syntax #198509

Closed
denis-sokolov opened this issue Nov 17, 2023 · 3 comments
Closed

Breaking change in vscode://file paths syntax #198509

denis-sokolov opened this issue Nov 17, 2023 · 3 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) triage-needed

Comments

@denis-sokolov
Copy link

denis-sokolov commented Nov 17, 2023

Type: Bug

A path like vscode://file//home/user/myProject/ has worked in the past and was correct according to a reasonable interpretation of the docs. After a recent change this format is no longer accepted. This breaks compatibility and requires countless 3rd-party tools to be updated (example). Worse, the new format is not generic across the operating systems, so the update for 3rd-party tools is not trivial.

Would you perhaps reconsider and continue support for existing links like vscode://file//home/user/myProject/?

Reproduction:

  1. Create a link to an existing file with this syntax: vscode://file//home/user/myProject/
  2. Click on the link.

Expected: the file or folder opens in VS Code.
Reality: the VS Code becomes focused, but does not open anything.

VS Code version: Code 1.84.2 (1a5daa3, 2023-11-09T10:52:57.054Z)
OS version: Darwin arm64 21.6.0

Related: #197319, microsoft/vscode-docs#6838.

@bpasero
Copy link
Member

bpasero commented Nov 17, 2023

/duplicate #197319

@vscodenpa vscodenpa added the *duplicate Issue identified as a duplicate of another issue(s) label Nov 17, 2023
@vscodenpa
Copy link

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for similar existing issues. See also our issue reporting guidelines.

Happy Coding!

@vscodenpa vscodenpa closed this as not planned Won't fix, can't repro, duplicate, stale Nov 17, 2023
@bpasero
Copy link
Member

bpasero commented Nov 17, 2023

Using insiders (where my fix landed) I am able to open vscode-insiders://file//Users/bpasero/Desktop/test-ts in the browser and get the workspace folder opened as it used to.

You can give our preview releases a try from: https://code.visualstudio.com/insiders/

@github-actions github-actions bot locked and limited conversation to collaborators Jan 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) triage-needed
Projects
None yet
Development

No branches or pull requests

4 participants