Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal shouldn't be focused if file cannot be run #24382

Open
injust opened this issue Nov 4, 2024 · 1 comment
Open

Terminal shouldn't be focused if file cannot be run #24382

injust opened this issue Nov 4, 2024 · 1 comment
Assignees
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug needs spike Label for issues that need investigation before they can be worked on.

Comments

@injust
Copy link

injust commented Nov 4, 2024

Behaviour

The "Python: Run Python File" commands focus the terminal unnecessarily if the file cannot be run.

Steps to reproduce:

  1. Enable "Python › Terminal: Focus After Launch" (python.terminal.focusAfterLaunch)
  2. Create an unsaved Python file or a saved non-Python file
  3. Run the "Python: Run Python File" command
  4. You get the error message "The active file needs to be saved before it can be run" or "The active file is not a Python source file", but the terminal still becomes focused
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Nov 4, 2024
@injust
Copy link
Author

injust commented Nov 5, 2024

#24396 is the root cause of this. See that issue for more details.

@anthonykim1 anthonykim1 added needs spike Label for issues that need investigation before they can be worked on. and removed triage-needed Needs assignment to the proper sub-team labels Nov 21, 2024
@eleanorjboyd eleanorjboyd added the bug Issue identified by VS Code Team member as probable bug label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-terminal bug Issue identified by VS Code Team member as probable bug needs spike Label for issues that need investigation before they can be worked on.
Projects
None yet
Development

No branches or pull requests

3 participants