Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Code for Terminal Environment Variable Experiment #23320

Closed
anthonykim1 opened this issue May 2, 2024 · 1 comment
Closed

Refactor Code for Terminal Environment Variable Experiment #23320

anthonykim1 opened this issue May 2, 2024 · 1 comment
Assignees
@anthonykim1
Labels
area-terminal debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team

Comments

@anthonykim1
Copy link

We should refactor: src/client/terminals/envCollectionActivation/service.ts in a way that we create two separate service for the new terminal environment variable experiment:

One service that would perform fetching environment variables via process (fallback option in case shell integration way doesn't work), another serivce that would fetch environment variables using shell integration enabled hidden terminal approach.
@anthonykim1 anthonykim1 added feature-request Request for new features or functionality area-terminal labels May 2, 2024
@anthonykim1 anthonykim1 self-assigned this May 2, 2024
@anthonykim1 anthonykim1 added debt Covers everything internal: CI, testing, refactoring of the codebase, etc. and removed feature-request Request for new features or functionality labels May 2, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label May 2, 2024
@anthonykim1
Copy link
Author

No longer needed, getting rid of the experiment: #24567

@anthonykim1 anthonykim1 closed this as not planned Won't fix, can't repro, duplicate, stale Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@anthonykim1 anthonykim1

Labels
area-terminal debt Covers everything internal: CI, testing, refactoring of the codebase, etc. triage-needed Needs assignment to the proper sub-team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anthonykim1