Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test poetry environments are autoselected #23116

Closed
3 tasks done
karrtikr opened this issue Mar 22, 2024 · 4 comments
Closed
3 tasks done

Test poetry environments are autoselected #23116

karrtikr opened this issue Mar 22, 2024 · 4 comments

Comments

@karrtikr
Copy link

karrtikr commented Mar 22, 2024

Refs: #19153

Complexity: 3

Create Issue


Requirements

  • Python extension pre-release

Verification

  • Install poetry if not already https://python-poetry.org/docs/#installing-with-the-official-installer
  • Create 3 empty projects
  • Open each project in terminal and run the following commands:
    • Initialize the poetry project, keep pressing Enter until finished:
      poetry init
      
    • Create a virtual environment and print executable
      poetry run python -c"import sys;print(sys.executable)"
      
    • Record the executable printed at end of it
      image
  • For each project:
    • Open the project as a workspace folder in VS Code and create a new Python file
    • Make sure the recorded python is the one which is selected:
      image
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Mar 22, 2024
@karrtikr karrtikr added testplan-item and removed triage-needed Needs assignment to the proper sub-team labels Mar 22, 2024
@github-actions github-actions bot added this to the March 2024 milestone Mar 25, 2024
@ulugbekna
Copy link

Doesn't seem to work for me 🤔

image

The selected python is at /opt/homebrew/bin/python3. Clicking on it shows a quick pick where the poetry project is present

image

@ulugbekna
Copy link

Tried again and it worked 🤷🏽‍♂️

@ulugbekna ulugbekna removed their assignment Mar 25, 2024
@rzhao271 rzhao271 removed their assignment Mar 25, 2024
@rzhao271
Copy link

LGTM on Linux with Python 3.11.6.
This is also my first time using Poetry. Poetry seems pretty cool

@karrtikr
Copy link
Author

karrtikr commented Mar 25, 2024

The selected python is at /opt/homebrew/bin/python3. Clicking on it shows a quick pick where the poetry project is present
Tried again and it worked 🤷🏽‍♂️

@ulugbekna The placeholder in quickpick seems to indicate that the correct environment was selected, but the status bar didn't seem to update. Seems like a UI bug, will look into it.

@Tyriar Tyriar removed their assignment Mar 26, 2024
@Tyriar Tyriar closed this as completed Mar 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants