Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testing: Add -v flag when running individual test #22953

Closed
NickCrews opened this issue Feb 21, 2024 · 2 comments
Closed

testing: Add -v flag when running individual test #22953

NickCrews opened this issue Feb 21, 2024 · 2 comments
Labels
area-testing feature-request Request for new features or functionality needs community feedback Awaiting community feedback

Comments

@NickCrews
Copy link

Thanks for the help here. Love the improvements you have been making. Especially the improved test discovery, result streaming, and test debugging support!

Just a possible UX improvement I would love. When I run an individual test with the UI:

image

I get this in the testing panel:

        first_few = list(
            result[["record_id_l", "record_id_r"]]
            .head(len(first_few_expected))
            .to_pandas()
            .itertuples(index=False, name=None)
        )
>       assert first_few_expected == list(first_few)
E       assert [(0, 1), (0, ..., (1, 3), ...] == [(0, 0), (0, ..., (1, 0), ...]
E         
E         At index 0 diff: (0, 1) != (0, 0)
E         Use -v to get more diff

mismo/block/tests/test_block_array.py:92: AssertionError
=========================== short test summary info ============================
FAILED mismo/block/tests/test_block_array.py::test_benchmark_array_blocker[n=10000,k=5,npairs=39,990]
============================== 1 failed in 0.24s ===============================
Finished running tests!

It would be awesome if the extension added the -v flag for me, so I would by default get the full diff. When I select a single test, that is probably because that individual case is failing, and so I want as much info as possible.

When running multiple tests, I think it makes sense to leave the behavior as is, keep it a bit more succinct, and leave the -v flag off.

@NickCrews NickCrews added the feature-request Request for new features or functionality label Feb 21, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Feb 21, 2024
@karthiknadig karthiknadig added the needs community feedback Awaiting community feedback label Feb 22, 2024
Copy link

Thanks for the feature request! We are going to give the community 60 days from when this issue was created to provide 7 👍 upvotes on the opening comment to gauge general interest in this idea. If there's enough upvotes then we will consider this feature request in our future planning. If there's unfortunately not enough upvotes then we will close this issue.

@karthiknadig karthiknadig added area-testing and removed triage-needed Needs assignment to the proper sub-team labels Feb 23, 2024
@brettcannon
Copy link
Member

Thank you for submitting your feature request and everyone who considered it! Unfortunately, this issue did not receive enough votes over the allotted time, and so we are closing the issue.

@brettcannon brettcannon closed this as not planned Won't fix, can't repro, duplicate, stale Jun 25, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing feature-request Request for new features or functionality needs community feedback Awaiting community feedback
Projects
None yet
Development

No branches or pull requests

4 participants
@brettcannon @karthiknadig @NickCrews and others