Deactivate command running but not deactivating auto-activated terminals

[cwebster-99]

Type: Bug

Behaviour

Expected vs. Actual

Testing with Windows and cmd, the deactivate command runs but the virtual environment is still activated when hovering over terminal panel.
XXX
I would expect it to show the global environment once the deactivate command runs.

@luabud could repro in wsl too

Steps to reproduce:

1. Open a workspace with a virtual environemnt.
2. Open a new cmd terminal, ensure environment is activated
3. type deactivate command
4. Hover over cmd terminal in panel to view activated terminal

Diagnostic data

• Python version (& distribution if applicable, e.g. Anaconda): 3.11.6
• Type of virtual environment used (e.g. conda, venv, virtualenv, etc.): Venv
• Value of the python.languageServer setting: Default

Output for Python in the Output panel (View→Output, change the drop-down the upper-right of the Output panel to Python)

XXX

User Settings

languageServer: "Pylance"

experiments
• optInto: ["pythonTerminalEnvVarActivation"]

Extension version: 2023.21.13321011
VS Code version: Code - Insiders 1.85.0-insider (b3b84b5239037a2f0ef8499306df9a3bacda4105, 2023-11-28T12:02:59.475Z)
OS version: Windows_NT x64 10.0.22621
Modes:

System Info

Item	Value
CPUs	AMD Ryzen 7 Microsoft Surface (R) Edition (16 x 1996)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled
Load (avg)	undefined
Memory (System)	7.45GB (0.18GB free)
Process Argv	-n --crash-reporter-id d43c6cb7-1956-4b45-bd15-ac990a27180d
Screen Reader	no
VM	0%

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368cf:30146710
vsreu685:30147344
python383:30185418
vspor879:30202332
vspor708:30202333
vspor363:30204092
vslsvsres303:30308271
pythontb:30258533
pythonptprofiler:30281269
vshan820:30294714
vscod805cf:30301675
bridge0708:30335490
bridge0723:30353136
vsaa593:30376534
pythonvs932:30404738
py29gd2263:30784851
vscaat:30438846
vsclangdf:30492506
c4g48928:30535728
dsvsc012:30540252
pynewext54:30618038
showlangstatbar:30737417
pythonfmttext:30716741
fixshowwlkth:30771523
showindicator:30805243
pythongtdpath:30726887
i26e3531:30792625
welcomedialog:30812478
pythonnosmt12:30779711
pythonidxpt:30768918
pythonnoceb:30776497
asynctok:30898717
dsvsc013:30777762
dsvsc014:30777825
pythonmpswarning:30859870
dsvsc015:30821418
pythontestfixt:30866404
pythonregdiag2:30871582
pyreplss1:30879911
pythonmypyd1:30859725
pythoncet0:30859736
pythontbext0:30879054
accentitlementst:30870582
dsvsc016:30879898
dsvsc017:30880771
dsvsc018:30880772
aa_t_chat:30882232

[karrtikr]

Discussed offline, but the hover description is just meant to carry the startup information, that the following extensions contributed (past tense) to this terminal environment. How that terminal environment changes later is up to the user, and we're not expected to track that.

The fact that (.venv) disappears should be enough for the user to realize that the environment has been deactivated.

[karrtikr]

@cwebster-99 In the first screenshot (.venv) isn't visible which seems like a bug, can you click "Show environment contributions" and see what was contributed?

[cwebster-99]

[karrtikr]

Closing this it was being caused due to cmd not being selected as default shell.