Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Home path should probably be retruning HTML response #22322

Closed
karthiknadig opened this issue Oct 24, 2023 · 1 comment
Closed

Home path should probably be retruning HTML response #22322

karthiknadig opened this issue Oct 24, 2023 · 1 comment
Assignees
@luabud
Labels
triage-needed Needs assignment to the proper sub-team

Comments

@karthiknadig
Copy link
Member

Testing #22302

@app.get("/")
def home(request: Request) -> Response:
    return Response(content='<html><body><p>Add /docs to the end of the URL to access the Swagger UI or <a href="/docs">click here</a></p></body></html>', headers={"Content-Type": "text/html; charset=utf-8"})
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Oct 24, 2023
@luabud luabud self-assigned this Oct 24, 2023
@karthiknadig karthiknadig changed the title home path should probably be html Home path should probably be retruning HTML response Oct 24, 2023
@luabud
Copy link
Member

luabud commented Oct 25, 2023

Good point! I ended up removing this route given I didn't mention it in the tutorial (microsoft/vscode-docs@5b8cdfc), and didn't want to make the tutorial even longer by explaining it. But great to keep this in my mind!

@luabud luabud closed this as not planned Won't fix, can't repro, duplicate, stale Oct 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@luabud luabud

Labels
triage-needed Needs assignment to the proper sub-team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@karthiknadig @luabud