Do not show activation notification for tasks or debug terminal

[roblourens]

I just started seeing this randomly. I could click "don't show again" but I don't think it should be showing in my scenario. This is in my multiroot workspace that includes vscode and an extension. I'm not doing anything with python or python files. I sometimes see this when I start debugging (the "VS Code" launch config) or when I open a new terminal. If I reload the window, it stops happening, but then comes back later at some point.

[karrtikr]

We activate Python extension in the following scenarios:

Does any of it match with your workspace?

[karrtikr]

If so, I'm not sure what can be done here, as for a Python related workspace, (Python) users expect us to activate all terminals if a virtual or conda env is selected.

[roblourens]

I don't think the debug initial configurations one would have triggered. I will check why the extension got activated.

But when is that supposed to be shown, is it working by design if it shows up every time I start a terminal?

I noticed that it shows up when I run a task, that is probably why it showed up when I started debugging earlier. Not sure if it should show for terminal tasks? That makes it especially noisy.

[karrtikr]

Right now it is meant to be a one time informational prompt which we show everytime window.onDidOpenTerminal is fired.

We can definitely clean this up to not show up on unrelated terminals (like tasks), just let us know which of the terminals we should skip based on the Terminal object: link cc/ @Tyriar

[Tyriar]

Not sure how we can target debug or task terminals, but it shouldn't be showing for terminals that don't get the collection applied which should match this if statement:

https://github.com/microsoft/vscode/blob/443f8cc0861e6a4eadd04a65d722af2c45ac3eca/src/vs/workbench/contrib/terminal/browser/terminalProcessManager.ts#L438

[karrtikr]

If we had access to tab description string:

we could filter task terminals using the "Tasks -" keyword:

[karrtikr]

I'm also happy with just showing that notification for terminals with the default profile name (like bash, zsh or other profile names), if we can access that.

[roblourens]

Right now it is meant to be a one time informational prompt

Is it supposed to show up just once per session? I've definitely seen it multiple times

[karrtikr]

No, we show it every time a new terminal is created, unless "Don't show again" is clicked.

[karrtikr]

I've investigated and it seems like terminal.creationOptions.name is set for tasks or debug terminals, hence we can avoid showing it in those cases.

I can also change it to only show once per session in case it is still bothersome.

[karrtikr]

Verification steps:

• Use pre-release
• Use Python: Clear cache and reload window command
• Open an empty folder, create a venv:

python -m venv .venv

• Select it using Python: Select Interpreter
• Select powershell or fish as default terminal
• Opening a new terminal should display:
  
• Create a simple task
• Ensure running task does not display the notification

[DonJayamanne]

I'm unable to verify this as I never get the prompt.

I've tried Python: Clera cache and reload window a number of times, and other steps as well
But I never get the prompt the Selected Python env... may not be present.

Btw, I have opted into all Python experiments.

[karrtikr]

Apologies, try using powershell or fish as default profile and the prompt should show up when opening a new terminal. I've amended the original instructions with the same.