tests don't stop when I click the stop botton

[meganrogge]

Testing #22081

I click the button three times here.

stop.mov

[eleanorjboyd]

Hi! I am trying to repro this and am unable to at this time. Could you look by chance to see what the unittest discovery error you are running into is? I see it at the bottom of the test explorer list. The logs for what the discovery error is would be in output under python. Thanks!

[meganrogge]

Here's what I see:

2023-09-27 13:52:08.996 [info] Test server listening.
2023-09-27 13:52:08.996 [info] Python interpreter path: /usr/local/bin/python3.10
2023-09-27 13:52:10.737 [info] Discover tests for workspace name: inc_dec_example_test_suite - uri: /Users/meganrogge/Repos/inc_dec_example_repo/inc_dec_example_test_suite
2023-09-27 13:52:10.737 [info] Running discovery for unittest using the new test adapter.
2023-09-27 13:52:11.927 [info] Discovering unittest tests with arguments: /Applications/code-insiders-portable-data/extensions/ms-python.python-2023.17.12701009/pythonFiles/unittestadapter/discovery.py,--port,57676,--uuid,00308add-021c-477f-9ff7-b887f115a043,--udiscovery,-v,-s,.,-p,*_test.py

2023-09-27 13:52:11.927 [info] > /usr/local/bin/python3.10 /Applications/code-insiders-portable-data/extensions/ms-python.python-2023.17.12701009/pythonFiles/unittestadapter/discovery.py --port 57676 --uuid 00308add-021c-477f-9ff7-b887f115a043 --udiscovery -v -s . -p *_test.py
2023-09-27 13:52:11.927 [info] cwd: .
2023-09-27 13:52:12.913 [info] Starting Pylance language server.
2023-09-27 13:52:13.032 [error] Subprocess exited unsuccessfully with exit code null and signal SIGSEGV
2023-09-27 13:52:13.032 [error] Subprocess exited unsuccessfully with exit code null and signal SIGSEGV. Creating and sending error discovery payload
2023-09-27 13:52:13.032 [error] Unittest test discovery error 
  
 The python test process was terminated before it could exit on its own, the process errored with: Code: null, Signal: SIGSEGV
2023-09-27 13:52:13.032 [info] ResultResolver EOT received for discovery.

[eleanorjboyd]

Do you see anything more in the logs after you click the run button? This seems to only be the logs for discovery and not for the subsequent run.

[meganrogge]

Tests aren't getting discovered for me at all at this pt since I reloaded the window as documented here #22093

[eleanorjboyd]

Passing this information onto @connor4312. What I am seeing here is the breakpoint connected to the place where the cancelation token is called and where it cancels the run is not being hit for a few seconds following the cancel button clicked.

breakpoint-on-cancel.mov

Additionally how fast I click to cancel seems to impact how quickly it can ultimately resolve.

cancel-attempt.mov

[eleanorjboyd]

related to: #21507

[connor4312]

I believe this is because the EH gets blocked right after end() is called, which prevents communication. Taking a profile (which makes it run a bit slower than normal) has about 15s of blocking time

~half this is just in the console.warn message the EH is printing when test states are modified after the run ends, and the other half is in the extension. However it would be better if we can avoid doing any work after cancellation happens, just killing the test process and ignoring anything further.

[eleanorjboyd]

closing in favor of #21507 to get all conversation around the "cancel" button not working under a single issue, thanks