Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assumption that macOS filesystem is case sensitive #22031

Open
karrtikr opened this issue Sep 19, 2023 · 0 comments
Open

Fix assumption that macOS filesystem is case sensitive #22031

karrtikr opened this issue Sep 19, 2023 · 0 comments
Labels
area-environments Features relating to handling interpreter environments area-terminal bug Issue identified by VS Code Team member as probable bug macos needs PR Ready to be worked on

Comments

@karrtikr
Copy link

karrtikr commented Sep 19, 2023

The default filesystem on Darwin is case insensitive: #22006. Look for all instances of places where we are only assuming Windows is case insensitive (converting paths to upper case or lower case just for windows). For eg.

And change it to also include macOS in that list. Note this may alter IDs for environments in macOS:

/**
* Gets general unique identifier for most environments.
*/
export function getEnvID(interpreterPath: string, envFolderPath?: string): string {
return normCasePath(getEnvPath(interpreterPath, envFolderPath).path);
}

So we should probably clear any existing environments discovered for macOS, simple way to do that is use a new key here, like PYTHON_ENV_INFO_CACHEv2:

const wasTriggered = getGlobalStorage<PythonEnvInfo[]>(ext.context, 'PYTHON_ENV_INFO_CACHE', []).get().length > 0;

@karrtikr karrtikr added bug Issue identified by VS Code Team member as probable bug area-terminal area-environments Features relating to handling interpreter environments needs PR Ready to be worked on labels Sep 19, 2023
@karrtikr karrtikr added the macos label Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-environments Features relating to handling interpreter environments area-terminal bug Issue identified by VS Code Team member as probable bug macos needs PR Ready to be worked on
Projects
None yet
Development

No branches or pull requests

1 participant