Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility: Several sub-components in environment manager lacks accessibility #61

Open
anthonykim1 opened this issue Dec 4, 2024 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@anthonykim1
Copy link

anthonykim1 commented Dec 4, 2024

Testing #24503

Couple components in the environment manager seem to have room for improvement in terms of accessibility.

  1. "Create Python Terminal" case:
    On screen reader mode, clicking on create Python terminal on environment manager doesnt give description/context of what is happening but rather just reads what goes inside terminal.
    I assume this may be very confusing to screen reader user because of sudden change of focus to terminal without any notification/description.
Screen.Recording.2024-12-04.at.12.31.18.AM.mov

The check mark icon which is right next to the terminal icon does a better job in a way that it tells "browse" so that the screen reader user should have better context. Not too sure why it wont say "terminal" or "create python terminal" for the terminal icon.

  1. Create environment icon and refresh environment icon case:
    Similarly, the create environment icon and refresh environment icon also does not provide any voice context over when pressed in screen reader mode (with voice over on)
    Image
@anthonykim1 anthonykim1 changed the title Accessibility) Clicking on "Create Python Terminal" lacks accessibility Accessibility) Several sub-components in environment manager lacks accessibility Dec 4, 2024
@karthiknadig karthiknadig transferred this issue from microsoft/vscode-python Dec 4, 2024
@karthiknadig karthiknadig changed the title Accessibility) Several sub-components in environment manager lacks accessibility Accessibility Several sub-components in environment manager lacks accessibility Dec 4, 2024
@karthiknadig karthiknadig changed the title Accessibility Several sub-components in environment manager lacks accessibility Accessibility: Several sub-components in environment manager lacks accessibility Dec 4, 2024
@karthiknadig
Copy link
Member

@meganrogge What can we do here to make it better?

@meganrogge
Copy link

meganrogge commented Dec 7, 2024

Re scenario number 1, does focusing the terminal button with the keyboard provide an informative aria label, like "create python terminal"? If not, I recommend adding an aria label to the button to indicate what will happen. The resulting terminal focus info is already enough to indicate that has happened.

Image

Re scenario number 2, for refreshing, could we use a progress indicator?

export interface Progress<T> {

		/**
		 * Report a progress update.
		 * @param value A progress item, like a message and/or an
		 * report on how much work finished
		 */
		report(value: T): void;
	}

For creating the environment, what gets focused when that is pressed?

@karthiknadig karthiknadig added this to the January 2025 milestone Dec 16, 2024
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

3 participants